Adds @kbn/utils package by tylersmalley · Pull Request #76518 · elastic/kibana

tylersmalley · 2020-09-02T15:07:53Z

This moves some common utility functions to obtain the repository root, paths (config/data), and Kibana package.json to a @kbn/utils package. Moving these existing functions allows them to be used in production across plugins and packages.

Related to #76874
Blocks #75521

Moves common utility functions to obtain the repository root, paths (config/data), and Kibana package.json to a @kbn/utils package. Moving these existing functions allows them to be used in production, in other packages because Kibana. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

elasticmachine · 2020-09-09T15:17:56Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-09-09T15:17:57Z

Pinging @elastic/kibana-platform (Team:Platform)

legrego

Security team changes LGTM

x-pack/test/spaces_api_integration/common/config.ts

src/core/server/server.ts

packages/kbn-utils/package.json

x-pack/plugins/canvas/server/routes/shareables/download.test.ts

x-pack/plugins/monitoring/server/config.test.ts

afharo

Telemetry changes LGTM!

Co-authored-by: Thomas Watson <w@tson.dk>

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

packages/kbn-utils/tsconfig.json

packages/kbn-utils/README.md

packages/kbn-utils/package.json

packages/kbn-utils/README.md

mshustov · 2020-09-10T13:48:54Z

src/cli_keystore/get_keystore.js


 import { Logger } from '../cli_plugin/lib/logger';
-import { getConfigDirectory, getDataPath } from '../core/server/path';
+import { getConfigDirectory, getDataPath } from '@kbn/utils';


Is it okay that getDataPath ignores a value configured in kibana.yml? We've even got an issue for this #43539

The plan is to first move this over, then resolve that issue - might wait for #76874 to assist with that.

mshustov · 2020-09-10T13:55:40Z

packages/kbn-utils/README.md

@@ -0,0 +1,3 @@
+# @kbn/utils
+
+Shared server-side utilities shared across packages and plugins.


btw are we sure that we'd never need Kibana-specific browser utils?

It's possible but thought it would be best to keep it focused to start.

I expect we will quickly start hearing stories of @kbn/utils gets pulled into the browser builds accidentally and failing because things like REPO_ROOT don't work in the browser (and will throw an error on page load, maybe even at build time).

It seems like we'll need to have separate entry points, like @kbn/utils/node and @kbn/utils/browser, which have slightly different APIs but share the exports they can. Still, something we can do in a follow-up as needed.

chrisronline

LGTM for stack monitoring, as long as CI is passing!

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

poffdeluxe

Canvas changes lgtm

mshustov · 2020-09-14T13:49:59Z

.github/CODEOWNERS

 /packages/kbn-test/ @elastic/kibana-operations
 /packages/kbn-ui-shared-deps/ @elastic/kibana-operations
 /packages/kbn-es-archiver/ @elastic/kibana-operations
+/packages/kbn-utils/ @elastic/kibana-operations


don't forget to remove this before back-porting.

mshustov

ok for the platform changes

spalger

LGTM, though I don't love jest-when and wonder if it might actually be more reasonable to start with a simple helper defined in x-pack/plugins/canvas/server/routes/shareables/download.test.ts rather than pulling in a package which bundles bunyan.

x-pack/plugins/monitoring/server/config.test.ts

kibanamachine · 2020-09-15T17:05:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7e58f7b

Build metrics

async chunks size

id	value	diff	baseline
enterpriseSearch	430.1KB	+49.0B	430.0KB

page load bundle size

id	value	diff	baseline
upgradeAssistant	64.8KB	+49.0B	64.7KB

distributable file count

id	value	diff	baseline
default	45574	+5	45569
oss	27252	+6	27246
total		+11

History

💚 Build #74189 succeeded bbf1a53
💚 Build #73792 succeeded 09d52f7
💛 Build #73463 was flaky b4a0772
💚 Build #73373 succeeded ea40aab
💔 Build #73284 failed cbdacce673d803ea82b958959eb11db8644e7e58

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Moves common utility functions to obtain the repository root, paths (config/data), and Kibana package.json to a @kbn/utils package. Moving these existing functions allows them to be used in production, in other packages because of Kibana. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Moves common utility functions to obtain the repository root, paths (config/data), and Kibana package.json to a @kbn/utils package. Moving these existing functions allows them to be used in production, in other packages because of Kibana. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [@kbn/utils] Adds missing dependency (#77536) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

…s-for-710 * 'master' of github.com:elastic/kibana: (95 commits) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) [@kbn/utils] Adds missing dependency (elastic#77536) Add the Enterprise Search logo to the Overview search result (elastic#77514) [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482) [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402) Adds @kbn/utils package (elastic#76518) Map layout changes (elastic#77132) [Security Solution] [Detections] EQL Rule Creation (elastic#76831) Adding test user to maps tests under documents source folder (elastic#77245) Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx

tylersmalley force-pushed the kbn-utils branch 4 times, most recently from 8e731a9 to 1d1b0e8 Compare September 8, 2020 00:34

tylersmalley mentioned this pull request Sep 8, 2020

Create the @kbn/std package #76925

Closed

tylersmalley force-pushed the kbn-utils branch 3 times, most recently from 2874cb6 to cbdacce Compare September 9, 2020 00:41

tylersmalley force-pushed the kbn-utils branch from cbdacce to ea40aab Compare September 9, 2020 13:26

tylersmalley mentioned this pull request Sep 9, 2020

Move core config service to kbn/config package #76874

Merged

2 tasks

tylersmalley added Team:Operations Kibana-Operations Team Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0 v8.0.0 labels Sep 9, 2020

tylersmalley marked this pull request as ready for review September 9, 2020 15:17

tylersmalley requested review from a team as code owners September 9, 2020 15:17

tylersmalley requested a review from a team September 9, 2020 15:17

tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Sep 9, 2020

legrego approved these changes Sep 9, 2020

View reviewed changes

watson reviewed Sep 9, 2020

View reviewed changes

afharo approved these changes Sep 9, 2020

View reviewed changes

Update src/core/server/server.ts

f35cb32

Co-authored-by: Thomas Watson <w@tson.dk>

Review feedback

b4a0772

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

mshustov reviewed Sep 10, 2020

View reviewed changes

chrisronline approved these changes Sep 10, 2020

View reviewed changes

tylersmalley added 3 commits September 10, 2020 07:00

review feedback

c9eef0e

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Update another REPO_ROOT reference

de06605

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Merge remote-tracking branch 'upstream/master' into kbn-utils

09d52f7

tylersmalley requested a review from a team as a code owner September 10, 2020 16:40

poffdeluxe approved these changes Sep 10, 2020

View reviewed changes

dmlemeshko approved these changes Sep 10, 2020

View reviewed changes

mshustov reviewed Sep 14, 2020

View reviewed changes

mshustov approved these changes Sep 14, 2020

View reviewed changes

Merge branch 'master' into kbn-utils

bbf1a53

spalger approved these changes Sep 14, 2020

View reviewed changes

x-pack/plugins/monitoring/server/config.test.ts Show resolved Hide resolved

lukeelmers approved these changes Sep 15, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-utils

7e58f7b

tylersmalley merged commit 9acf8d2 into elastic:master Sep 15, 2020

tylersmalley mentioned this pull request Sep 15, 2020

[7.x] Adds @kbn/utils package (#76518) #77525

Closed

tylersmalley mentioned this pull request Sep 15, 2020

[7.x] Adds @kbn/utils package (#76518) #77531

Merged

		@@ -0,0 +1,3 @@
		# @kbn/utils

		Shared server-side utilities shared across packages and plugins. No newline at end of file

Conversation

tylersmalley commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Sep 9, 2020

Uh oh!

elasticmachine commented Sep 9, 2020

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mshustov Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

mshustov Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

mshustov Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

mshustov left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Sep 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

distributable file count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

tylersmalley commented Sep 2, 2020 •

edited

Loading

spalger Sep 14, 2020 •

edited

Loading