[Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case by cnasikas · Pull Request #76967 · elastic/kibana

cnasikas · 2020-09-08T18:05:02Z

Summary

The PR fixes a bug where an error occurred when trying to attach a timeline to an existing case or to a new case.

Attach timeline to a new case

Attach timeline to an existing case

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-08T18:05:04Z

Pinging @elastic/siem (Team:SIEM)

cnasikas · 2020-09-14T16:31:08Z

@elasticmachine merge upstream

stephmilovic

code and manual testing LGTM. looks like you may need help from @MadameSheema on getting the cypress passing consistently.

cnasikas · 2020-09-15T07:19:53Z

@elasticmachine merge upstream

...olution/public/timelines/components/timeline/insert_timeline_popover/use_insert_timeline.tsx

patrykkopycinski · 2020-09-15T07:26:55Z

...olution/public/timelines/components/timeline/insert_timeline_popover/use_insert_timeline.tsx

+  // insertTimeline selector is defined to attached a timeline to a case outside of the case page.
+  // FYI, if you are in the case page we only use handleOnTimelineChange to attach a timeline to a case.
+  useEffect(() => {
+    const currentValue = form.getFormData()[fieldName];


@sebelga could you take a look at that?

It would be better to use the useFormData hook and directly provide the field value to this hook. For example, the AddComment would be

const { form } = useForm<CommentRequest>({ defaultValue: initialCommentValue, options: { stripEmptyFields: false }, schema, }); const { setFieldValue, reset, submit } = form; // Get the updated field value const [{ comment }] = useFormData({ form, watch: ['comment'] }); // Pass it to the hook const { handleCursorChange, handleOnTimelineChange } = useInsertTimeline<CommentRequest>(comment); // I am not sure I understand what this does... // If you need to format the field value on each keystroke, use a "formatter" on the field // If you need to format the field when initiated, use a "deserializer" on the field. const addQuote = useCallback( (quote) => { setFieldValue('comment', `${comment}${comment.length > 0 ? '\n\n' : ''}${quote}`); }, [comment, setFieldValue] );

@sebelga Thank you for your feedback! The addQuote function takes the content of a comment and make it a quote. This will only happen when the user clicks the add quote button and not on each keystroke or at the initiation of the field.

I see, thanks for the explanation @cnasikas

patrykkopycinski

Thank you for using useFormData hook and adding Cypress tests, LGTM ❤️ 💪

cnasikas · 2020-09-15T11:40:05Z

@elasticmachine merge upstream

kibanamachine · 2020-09-15T19:59:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a009f8e

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	10.0MB	+4.0KB	10.0MB

distributable file count

id	value	diff	baseline
default	45553	+1	45552

History

💔 Build #74444 failed 4e08f57
💔 Build #74428 failed 1361761
💔 Build #74414 failed 5859391
💔 Build #74365 failed c02ee6f
💔 Build #74213 failed 04c50de

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… to a case (elastic#76967) Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…meline to a case (#76967) (#77547) Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…s-for-710 * 'master' of github.com:elastic/kibana: (95 commits) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) [@kbn/utils] Adds missing dependency (elastic#77536) Add the Enterprise Search logo to the Overview search result (elastic#77514) [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482) [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402) Adds @kbn/utils package (elastic#76518) Map layout changes (elastic#77132) [Security Solution] [Detections] EQL Rule Creation (elastic#76831) Adding test user to maps tests under documents source folder (elastic#77245) Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx

* master: (55 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (54 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (76 commits) Fixing service maps API test (elastic#77586) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) ...

elasticmachine · 2021-09-23T14:25:53Z

Pinging @elastic/security-solution (Team: SecuritySolution)

cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 8, 2020

cnasikas requested review from a team as code owners September 8, 2020 18:05

cnasikas added the bug Fixes for quality problems that affect the customer experience label Sep 8, 2020

cnasikas force-pushed the fix_case_timeline_bug branch from 3f56d8d to 038ffef Compare September 8, 2020 18:14

cnasikas added 3 commits September 14, 2020 12:03

Move check of timeline in useInsertTimeline

ded3f6e

Add tests

7708742

Add cypress tests

fc4e97a

cnasikas force-pushed the fix_case_timeline_bug branch from 117421c to fc4e97a Compare September 14, 2020 09:06

MadameSheema added 2 commits September 14, 2020 11:58

improves execution time of the tests

d78f5cb

test refactor

352f699

Merge branch 'master' into fix_case_timeline_bug

04c50de

stephmilovic approved these changes Sep 14, 2020

View reviewed changes

cnasikas mentioned this pull request Sep 14, 2020

[Security Solutions][Cases] Cases Redesign #73247

Merged

6 tasks

Merge branch 'master' into fix_case_timeline_bug

c02ee6f

patrykkopycinski reviewed Sep 15, 2020

View reviewed changes

...olution/public/timelines/components/timeline/insert_timeline_popover/use_insert_timeline.tsx Outdated Show resolved Hide resolved

patrykkopycinski reviewed Sep 15, 2020

View reviewed changes

Use new form data hook

5859391

patrykkopycinski approved these changes Sep 15, 2020

View reviewed changes

elasticmachine and others added 3 commits September 15, 2020 05:40

Merge branch 'master' into fix_case_timeline_bug

1361761

fixes failing tests

4e08f57

updates archiver

a009f8e

cnasikas merged commit 7524891 into elastic:master Sep 15, 2020

cnasikas deleted the fix_case_timeline_bug branch September 15, 2020 20:48

cnasikas mentioned this pull request Sep 15, 2020

[7.x] [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (#76967) #77547

Merged

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case#76967

[Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case#76967
cnasikas merged 11 commits intoelastic:masterfrom
cnasikas:fix_case_timeline_bug

cnasikas commented Sep 8, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Sep 8, 2020

Uh oh!

cnasikas commented Sep 14, 2020

Uh oh!

stephmilovic left a comment

Uh oh!

cnasikas commented Sep 15, 2020

Uh oh!

Uh oh!

patrykkopycinski Sep 15, 2020

Uh oh!

sebelga Sep 15, 2020

Uh oh!

cnasikas Sep 15, 2020

Uh oh!

sebelga Sep 16, 2020

Uh oh!

patrykkopycinski left a comment

Uh oh!

cnasikas commented Sep 15, 2020

Uh oh!

kibanamachine commented Sep 15, 2020

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

cnasikas commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Attach timeline to a new case

Attach timeline to an existing case

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 8, 2020

Uh oh!

cnasikas commented Sep 14, 2020

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Sep 15, 2020

Uh oh!

Uh oh!

patrykkopycinski Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

cnasikas Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

sebelga Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Sep 15, 2020

Uh oh!

kibanamachine commented Sep 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

distributable file count

History

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cnasikas commented Sep 8, 2020 •

edited

Loading