[Security Solution][Resolver] Analyzed event styling#77115
[Security Solution][Resolver] Analyzed event styling#77115michaelolo24 merged 5 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
There was a problem hiding this comment.
Maintaining the same outline color since the more translucent outline now signifies the analyzed event
There was a problem hiding this comment.
Added a second backing layer for the origin rather than modifying the existing one to maintain the outline effect on top of the more translucent line. If there is a better way to do this lmk.
There was a problem hiding this comment.
ℹ️ Does this make it through the use shadow boundary? This is something I have to look up again and again every time it comes up: https://tympanus.net/codrops/2015/07/16/styling-svg-use-content-css/
There was a problem hiding this comment.
Yeah, so I guess the fill does get through the boundary using the presentation attribute on the outer use.
x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
For my own edification, what's the difference with using the arrow function vs just passing in selectors.resolverComponentInstanceID? Does it not pass the state by default?
There was a problem hiding this comment.
Thanks, it doesn't change anything actually. I just thought some of these weren't updated based on some other useSelector changes I remembered seeing, but those changes were primarily due to how useSelector handles thunks, but these aren't thunks so it was an unnecessary change. I reverted it 😄
2c2273c to
12fd862
Compare
There was a problem hiding this comment.
Maybe put the 'analyzed event' text, the dot, and the descriptionText into a single formatted message. This will allow translators to, for example, swap out the dot with something locale specific, or reverse the order.
There was a problem hiding this comment.
Yea, makes sense. I've updated it
4f6ae90 to
fb249df
Compare
fb249df to
eabe8c1
Compare
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
* master: (65 commits) [Security Solution][Resolver] Analyzed event styling (elastic#77115) filter invalid SOs from the searc hresults in Task Manager (elastic#76891) [RUM Dashboard] Visitors by region map (elastic#77135) [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555) [Ingest pipelines] Forms for processors T-U (elastic#76710) updating datatable type (elastic#77320) [ML] Fix custom URLs processing for security app (elastic#76957) [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747) [ML] Transforms: API schemas and integration tests (elastic#75164) [Mappings editor] Add support for wildcard field type (elastic#76574) [Ingest Manager] Fix flyout instruction selection (elastic#77071) [Telemetry Tools] update lodash to 4.17 (elastic#77317) [APM] Service inventory redesign (elastic#76744) Hide management sections based on cluster/index privileges (elastic#67791) [Snapshot Restore] Disable steps when form is invalid (elastic#76540) [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824) Update apm.ts (elastic#77310) [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164) [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986) [APM] API Snapshot Testing (elastic#77229) ...
* master: (65 commits) [Security Solution][Resolver] Analyzed event styling (elastic#77115) filter invalid SOs from the searc hresults in Task Manager (elastic#76891) [RUM Dashboard] Visitors by region map (elastic#77135) [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555) [Ingest pipelines] Forms for processors T-U (elastic#76710) updating datatable type (elastic#77320) [ML] Fix custom URLs processing for security app (elastic#76957) [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747) [ML] Transforms: API schemas and integration tests (elastic#75164) [Mappings editor] Add support for wildcard field type (elastic#76574) [Ingest Manager] Fix flyout instruction selection (elastic#77071) [Telemetry Tools] update lodash to 4.17 (elastic#77317) [APM] Service inventory redesign (elastic#76744) Hide management sections based on cluster/index privileges (elastic#67791) [Snapshot Restore] Disable steps when form is invalid (elastic#76540) [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824) Update apm.ts (elastic#77310) [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164) [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986) [APM] API Snapshot Testing (elastic#77229) ...
Summary
1. Adds styling for the node that was selected from the timeline for Analysis.
2. Selection outline for nodes are now all the same (i.e. running and terminated nodes have same darker blue outline)
Checklist
Delete any items that are not applicable to this PR.