Task/endpointlist actions by parkiino · Pull Request #76555 · elastic/kibana

parkiino · 2020-09-02T18:55:53Z

Summary

Issue: https://github.com/elastic/security-team/issues/115

Adds an Actions column to the Endpoint List
Action Menu contains 3 links: Security Solution Hosts Page, Ingest Agent Details Page, and Ingest Policy Details Page
Tests
Additionally adds an update to the ingest manager script to enroll an agent

gif doesn't include the last action, because the correct agent id wasn't grabbed when i mocked the data, the link works tho

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-02T18:55:56Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-09-02T18:55:56Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-09-02T18:55:58Z

Pinging @elastic/ingest-management (Team:Ingest Management)

nchaulet · 2020-09-02T19:00:24Z

x-pack/plugins/ingest_manager/scripts/dev_agent/script.ts

        ip: '127.0.0.1',
        system: `${os.type()} ${os.release()}`,
        memory: os.totalmem(),
+        elastic: { agent: { version: '8.0.0' } },


maybe we can rely on kibana package.json version here?

👍

@parkiino that's something that I was also planning to do in the pending PR that enhances our dev data generator loader utility

ok good to know

paul-tavares · 2020-09-03T12:52:04Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/types.ts

  /** tracks the list of policies IDs used in Host metadata that may no longer exist */
  nonExistingPolicies: Record<string, boolean>;
+  /** List of Agent Policies Ids*/
+  agentPolicies: Record<string, string>;


Maybe:

Suggested change

agentPolicies: Record<string, string>;

agentPolicies: PolicyIds['agentPolicy']

paul-tavares · 2020-09-03T12:55:07Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/types.ts

  endpointPackageInfo?: GetPackagesResponse['response'][0];
  /** tracks the list of policies IDs used in Host metadata that may no longer exist */
  nonExistingPolicies: Record<string, boolean>;
+  /** List of Agent Policies Ids*/


Can you expand the description here a bit. Maybe:

Suggested change

/** List of Agent Policies Ids*/

/** A a list of Package Policy IDs (received via Endpoint metadata/policy response) mapped to associated Fleet parent Agent Config */

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/types.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

paul-tavares · 2020-09-03T13:19:27Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

+                        data-test-subj="hostLink"
+                        appId="securitySolution"
+                        appPath={`hosts/${item.metadata.host.hostname}`}
+                        href={`${services?.application?.getUrlForApp('securitySolution')}/hosts/${


For the Security Solution URLs, I think methods exists (similar to the ones we have) that return both the path and the href. We should use those instead of building these paths manually

paul-tavares · 2020-09-03T13:27:22Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

+                        appPath={`#/policies/${
+                          agentPolicies[item.metadata.Endpoint.policy.applied.id]
+                        }`}
+                        href={`${services?.application?.getUrlForApp('ingestManager')}#/policies/${


I just found that Ingest also has a set of methods that allows us to get the path to the different pages:

kibana/x-pack/plugins/ingest_manager/public/applications/ingest_manager/constants/page_paths.ts

Lines 59 to 84 in 3031e66

export const pagePathGetters: {

[key in StaticPage]: () => string;

} &

{

[key in DynamicPage]: (values: DynamicPagePathValues) => string;

} = {

overview: () => '/',

integrations: () => '/integrations',

integrations_all: () => '/integrations',

integrations_installed: () => '/integrations/installed',

integration_details: ({ pkgkey, panel }) =>

`/integrations/detail/${pkgkey}${panel ? `/${panel}` : ''}`,

policies: () => '/policies',

policies_list: () => '/policies',

policy_details: ({ policyId, tabId }) => `/policies/${policyId}${tabId ? `/${tabId}` : ''}`,

add_integration_from_policy: ({ policyId }) => `/policies/${policyId}/add-integration`,

add_integration_to_policy: ({ pkgkey }) => `/integrations/${pkgkey}/add-integration`,

edit_integration: ({ policyId, packagePolicyId }) =>

`/policies/${policyId}/edit-integration/${packagePolicyId}`,

fleet: () => '/fleet',

fleet_agent_list: ({ kuery }) => `/fleet/agents${kuery ? `?kuery=${kuery}` : ''}`,

fleet_agent_details: ({ agentId, tabId }) =>

`/fleet/agents/${agentId}${tabId ? `/${tabId}` : ''}`,

fleet_enrollment_tokens: () => '/fleet/enrollment-tokens',

data_streams: () => '/data-streams',

};

This however, does not seem to be exported at the ingest_manager/public level, so we can't reference it just yet. but maybe we open a separate issue to use it and then refactor this here (and possibly other locations in our code) to use it?

cc:/ @jen-huang , @nchaulet 😬

feel free to export and use this whenever :)

…-actions

…a into task/endpointlist-actions

…-actions

parkiino · 2020-09-10T15:20:41Z

.../security_solution/public/management/pages/endpoint_hosts/store/mock_endpoint_result_list.ts

    // just returns 1 single agent policy that includes all of the packagePolicy IDs provided
    [INGEST_API_AGENT_POLICIES]: (): GetAgentPoliciesResponse => {
-      const agentPolicy = generator.generateAgentPolicy();
+      //  const agentPolicy = generator.generateAgentPolicy();


will remove this

…-actions

kevinlog

LGTM 👍

…-actions

kibanamachine · 2020-09-13T16:22:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ebc2db1

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	10.0MB	+15.5KB	10.0MB

page load bundle size

id	value	diff	baseline
ingestManager	468.6KB	+268.0B	468.4KB
securitySolution	793.2KB	+240.0B	793.0KB
total		+508.0B

History

💔 Build #73949 failed a16b8ab
💔 Build #73875 failed 756125d
💔 Build #73847 failed e0b213d
💚 Build #73702 succeeded 165beb6
💔 Build #73587 failed 075b8c9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares

LGTM 👍

🚀

paul-tavares · 2020-09-14T15:20:33Z

x-pack/plugins/ingest_manager/scripts/dev_agent/script.ts

 } from '../../common/types';
+import * as kibanaPackage from '../../package.json';

+// @ts-ignore


Interesting - what was the TS error?

* master: (65 commits) [Security Solution][Resolver] Analyzed event styling (elastic#77115) filter invalid SOs from the searc hresults in Task Manager (elastic#76891) [RUM Dashboard] Visitors by region map (elastic#77135) [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555) [Ingest pipelines] Forms for processors T-U (elastic#76710) updating datatable type (elastic#77320) [ML] Fix custom URLs processing for security app (elastic#76957) [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747) [ML] Transforms: API schemas and integration tests (elastic#75164) [Mappings editor] Add support for wildcard field type (elastic#76574) [Ingest Manager] Fix flyout instruction selection (elastic#77071) [Telemetry Tools] update lodash to 4.17 (elastic#77317) [APM] Service inventory redesign (elastic#76744) Hide management sections based on cluster/index privileges (elastic#67791) [Snapshot Restore] Disable steps when form is invalid (elastic#76540) [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824) Update apm.ts (elastic#77310) [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164) [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986) [APM] API Snapshot Testing (elastic#77229) ...

kibanamachine · 2020-09-16T15:58:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 76555 or prevent reminders by adding the backport:skip label.

…) (#77636) Endpoint list actions to security solution endpoint admin Co-authored-by: Paul Tavares <paul.tavares@elastic.co>

parkiino added 3 commits September 2, 2020 14:47

all three linkies

7b81227

wip grabbing agent policy id

0001d29

all links working

f1ef86a

parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.10.0 labels Sep 2, 2020

parkiino requested a review from a team as a code owner September 2, 2020 18:55

parkiino requested a review from a team September 2, 2020 18:55

parkiino requested a review from a team as a code owner September 2, 2020 18:55

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 2, 2020

nchaulet reviewed Sep 2, 2020

View reviewed changes

paul-tavares reviewed Sep 3, 2020

View reviewed changes

parkiino and others added 7 commits September 8, 2020 10:31

comments, use package version, wip tests

7e4e171

Merge remote-tracking branch 'upstream/master' into task/endpointlist…

b8096de

…-actions

tests are working

7030339

I did a thing

85127ae

Merge remote-tracking branch 'upstream/master' into task/endpointlist…

72925ef

…-actions

Merge branch 'task/endpointlist-actions' of github.com:parkiino/kiban…

075b8c9

…a into task/endpointlist-actions

Merge remote-tracking branch 'upstream/master' into task/endpointlist…

165beb6

…-actions

parkiino commented Sep 10, 2020

View reviewed changes

parkiino added 4 commits September 10, 2020 15:30

remove linktoapp

d1fbf41

Merge remote-tracking branch 'upstream/master' into task/endpointlist…

e0b213d

…-actions

use ingest path getter

74df432

remove unused import

756125d

kevinlog approved these changes Sep 10, 2020

View reviewed changes

parkiino added 2 commits September 12, 2020 00:00

fix up functional tests

a16b8ab

Merge remote-tracking branch 'upstream/master' into task/endpointlist…

ebc2db1

…-actions

paul-tavares approved these changes Sep 14, 2020

View reviewed changes

parkiino merged commit 1a49c4e into elastic:master Sep 14, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 16, 2020

parkiino mentioned this pull request Sep 16, 2020

[7.x] [Security Solution][Endpoint][Admin] Task/endpoint list actions (#76555) #77636

Merged

parkiino added a commit that referenced this pull request Sep 16, 2020

[Security Solution][Endpoint][Admin] Task/endpoint list actions (#76555…

162ed34

…) (#77636) Endpoint list actions to security solution endpoint admin Co-authored-by: Paul Tavares <paul.tavares@elastic.co>

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 16, 2020

parkiino deleted the task/endpointlist-actions branch September 16, 2020 18:45

	agentPolicies: Record<string, string>;
	agentPolicies: PolicyIds['agentPolicy']

	/** List of Agent Policies Ids*/
	/** A a list of Package Policy IDs (received via Endpoint metadata/policy response) mapped to associated Fleet parent Agent Config */

	export const pagePathGetters: {
	[key in StaticPage]: () => string;
	} &
	{
	[key in DynamicPage]: (values: DynamicPagePathValues) => string;
	} = {
	overview: () => '/',
	integrations: () => '/integrations',
	integrations_all: () => '/integrations',
	integrations_installed: () => '/integrations/installed',
	integration_details: ({ pkgkey, panel }) =>
	`/integrations/detail/${pkgkey}${panel ? `/${panel}` : ''}`,
	policies: () => '/policies',
	policies_list: () => '/policies',
	policy_details: ({ policyId, tabId }) => `/policies/${policyId}${tabId ? `/${tabId}` : ''}`,
	add_integration_from_policy: ({ policyId }) => `/policies/${policyId}/add-integration`,
	add_integration_to_policy: ({ pkgkey }) => `/integrations/${pkgkey}/add-integration`,
	edit_integration: ({ policyId, packagePolicyId }) =>
	`/policies/${policyId}/edit-integration/${packagePolicyId}`,
	fleet: () => '/fleet',
	fleet_agent_list: ({ kuery }) => `/fleet/agents${kuery ? `?kuery=${kuery}` : ''}`,
	fleet_agent_details: ({ agentId, tabId }) =>
	`/fleet/agents/${agentId}${tabId ? `/${tabId}` : ''}`,
	fleet_enrollment_tokens: () => '/fleet/enrollment-tokens',
	data_streams: () => '/data-streams',
	};

Conversation

parkiino commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 2, 2020

Uh oh!

elasticmachine commented Sep 2, 2020

Uh oh!

elasticmachine commented Sep 2, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parkiino Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevinlog left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 13, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

parkiino commented Sep 2, 2020 •

edited

Loading

parkiino Sep 3, 2020 •

edited

Loading