Skip to content

IndexMigrator: fix non blocking migration wrapper promise rejection#77018

Merged
pgayvallet merged 2 commits intoelastic:masterfrom
pgayvallet:kbn-75055-fix-transformn-non-blocking
Sep 9, 2020
Merged

IndexMigrator: fix non blocking migration wrapper promise rejection#77018
pgayvallet merged 2 commits intoelastic:masterfrom
pgayvallet:kbn-75055-fix-transformn-non-blocking

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

@pgayvallet pgayvallet commented Sep 9, 2020 •
edited
Loading

Summary

Fix #75055

Fix the transformNonBlocking method that was not properly handling errors thrown from the transform function

Release Note

Fix a bug causing savedObject migration errors to not being displayed in the logs.

Checklist

@pgayvallet pgayvallet mentioned this pull request Sep 9, 2020
Closed
1 task
@pgayvallet pgayvallet added release_note:fix v7.10.0 v7.9.2 Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Sep 9, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 9, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review September 9, 2020 10:48
@pgayvallet pgayvallet requested a review from a team as a code owner September 9, 2020 10:48
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 9, 2020

Pinging @elastic/kibana-platform (Team:Platform)

mshustov
mshustov approved these changes Sep 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic problem of async error handling 😅

@pgayvallet pgayvallet merged commit 7fc4bb3 into elastic:master Sep 9, 2020
@pgayvallet pgayvallet mentioned this pull request Sep 9, 2020
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Sep 9, 2020
@pgayvallet
IndexMigrator: fix non blocking migration wrapper promise rejection (e…
2725b1b 
…lastic#77018)

* fix transformNonBlocking

* add test for indexMigrator
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Sep 9, 2020
@pgayvallet
IndexMigrator: fix non blocking migration wrapper promise rejection (e…
e963490 
…lastic#77018)

* fix transformNonBlocking

* add test for indexMigrator
@pgayvallet pgayvallet mentioned this pull request Sep 9, 2020
Merged
pgayvallet added a commit that referenced this pull request Sep 9, 2020
@pgayvallet
IndexMigrator: fix non blocking migration wrapper promise rejection (#…
fa1a8cf 
…77018) (#77092)

* fix transformNonBlocking

* add test for indexMigrator
pgayvallet added a commit that referenced this pull request Sep 10, 2020
@pgayvallet
[7.9] IndexMigrator: fix non blocking migration wrapper promise rejec…
f8a3f5a 
…tion (#77018) (#77093)

* IndexMigrator: fix non blocking migration wrapper promise rejection (#77018)

* fix transformNonBlocking

* add test for indexMigrator

* adapt test for 7.9
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
2940bb2 
* master: (25 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerts/improve-find-pref
9d86fcd 
* master: (41 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
e4489fe 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (39 commits)
  [APM] Always load esarchives from common (elastic#77139)
  [Ingest Manager] Handle Legacy ES client errors (elastic#76865)
  [Docs] URL Drilldown (elastic#76529)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/static/forms/hook_form_lib/components/use_array.ts
rylnd added a commit to rylnd/kibana that referenced this pull request Sep 10, 2020
@rylnd
Merge branch 'master' into eql_rules_creation
5094b04 
* master: (38 commits)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  [Metrics UI] Replace Snapshot API with Metrics API (elastic#76253)
  legacy utils cleanup (elastic#76608)
  [ML] Account for "properties" layer in find_file_structure mappings (elastic#77035)
  fixed typo
  Upgrade to Kea 2.2 (elastic#77047)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:fix Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.9.2 v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DocumentMigrator exception not handled by logger

4 participants

@pgayvallet @kibanamachine @elasticmachine @mshustov