a11y tests on spaces home page including feature control by bhavyarm · Pull Request #76515 · elastic/kibana

bhavyarm · 2020-09-02T14:55:26Z

a11y tests for spaces and feature control home page
Meta issue - #51456

bhavyarm · 2020-09-03T13:43:44Z

@myasonik can you please take a look at the code and the changes I made? I am rolling through different errors in CI and in my local. So not sure what is happening. Thanks!

…y error

bhavyarm · 2020-09-04T14:06:53Z

@elasticmachine merge upstream

x-pack/test/accessibility/apps/spaces.ts

jportner

Spaces management changes LGTM!

Some optional suggestions if you agree:

Existing Spaces data-test-subj's make use of a prefix (e.g., Copy to space uses cts-). Maybe these could be prefixed as well to ensure they are unique? Perhaps space-mgmt-.
The data-test-subj's that I've worked with usually have some sort of descriptive suffix, like cts-finish-button or -radioGroup. That can be helpful when working with functional tests to ensure you're using the correct approach for interacting with that element in Selenium... maybe it's just simulating a click, or something else.

...ck/plugins/spaces/public/management/components/secure_space_message/secure_space_message.tsx

x-pack/plugins/spaces/public/management/edit_space/enabled_features/feature_table.tsx

…e_message/secure_space_message.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

myasonik

🚀

LeeDr

LGTM - I didn't pull and run locally. Just code review and Jenkins results.

bhavyarm · 2020-09-08T13:03:08Z

@elasticmachine merge upstream

bhavyarm · 2020-09-08T14:44:43Z

@elasticmachine merge upstream

bhavyarm · 2020-09-08T14:45:46Z

@myasonik this PR is failing again on nth focus but I did add dismiss toasts to this test:

  it('a11y test for manage spaces page', async () => {
      await toasts.dismissAllToasts();
      await PageObjects.spaceSelector.clickManageSpaces();
      await PageObjects.header.waitUntilLoadingHasFinished();
      await a11y.testAppSnapshot();
    });

Running it again but worried this might make it flakey. Let me know what do you think about it? Thanks!

bhavyarm · 2020-09-08T17:51:06Z

Flaky test run - https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/828/

bhavyarm · 2020-09-08T19:33:04Z

@elasticmachine merge upstream

bhavyarm · 2020-09-09T10:51:36Z

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/829/ after @myasonik's awesome fix!

bhavyarm · 2020-09-09T10:51:50Z

@elasticmachine merge upstream

kibanamachine · 2020-09-09T12:49:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6fbc899

Build metrics

page load bundle size

id	value	diff	baseline
spaces	488.9KB	+666.0B	488.2KB

History

💚 Build #73257 succeeded 5f6ae0c
💔 Build #73213 failed ced456b
💔 Build #73179 failed 3791095
💚 Build #73140 succeeded 6344792
💔 Build #73096 failed 40282fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (68 commits) a11y tests on spaces home page including feature control (elastic#76515) [ML] Transforms list: persist pagination through refresh interval (elastic#76786) [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876) [Timelion] Update timelion deprecation links (elastic#77008) [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928) Upgrade elastic charts to 21.1.2 (elastic#76939) [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778) [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861) Update saved object management UI text (elastic#76826) [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949) [Logs UI] Use fields api in log stream (elastic#76919) [UI Metrics] Support multi-colon keys (elastic#76913) [APM] Script for creating functional test archive (elastic#76926) [ENDPOINT] First version of the trusted apps list. (elastic#76304) Correct field for rum page url (elastic#76916) [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868) Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924) [RUM Dashboard] Visitor breakdown usability (elastic#76834) [Search] Add a new advanced setting searchTimeout (elastic#75728) [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959) ...

…7120)

* master: (38 commits) Reporting/Test: unskip non-screenshot tests (elastic#77088) Move metrics to setup and add cgroup metrics (elastic#76730) [Enterprise Search] Add Overview landing page/plugin (elastic#76734) First pass. Change TS type. Update OpenAPI (elastic#76434) [CI] Balance xpack ci groups a bit (elastic#77068) [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531) [Maps] convert MetricsEditor to TS (elastic#76727) IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018) [Enterprise Search] Update config data endpoint to v2 (elastic#76970) [ML] Add decision path charts to exploration results table (elastic#73561) Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016) [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981) [Metrics UI] Replace Snapshot API with Metrics API (elastic#76253) legacy utils cleanup (elastic#76608) [ML] Account for "properties" layer in find_file_structure mappings (elastic#77035) fixed typo Upgrade to Kea 2.2 (elastic#77047) a11y tests on spaces home page including feature control (elastic#76515) [ML] Transforms list: persist pagination through refresh interval (elastic#76786) [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876) ...

bhavyarm added 3 commits August 26, 2020 17:14

spaces a11y tests

22498f9

a11y tests for spaces home and feature control

85463cc

merging main

753147e

bhavyarm added v8.0.0 Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes labels Sep 2, 2020

bhavyarm added 3 commits September 2, 2020 12:07

correcting type errors

9c8b2d2

updating jest snapshots

e3393bb

Merge branch 'master' into a11ySpaces

ba90233

bhavyarm mentioned this pull request Sep 2, 2020

[EuiColorPicker] Accessibility violations (in manage spaces page) elastic/eui#3999

Closed

bhavyarm added 2 commits September 2, 2020 17:18

adding assertion checks on existence of manage spaces button

9ecbc01

adding exists test subject to figure out unique id error on show

dfc7bfd

bhavyarm self-assigned this Sep 3, 2020

Michail Yasonik and others added 3 commits September 3, 2020 11:35

removing unnecessary id

171485e

clear inacessible toasts

a6c0f80

adding dismiss toasts to navigate back to spaces to fix nth child a11…

2fada76

…y error

Merge branch 'master' into a11ySpaces

85dd8ae

bhavyarm marked this pull request as ready for review September 4, 2020 15:59

bhavyarm requested a review from a team as a code owner September 4, 2020 15:59

bhavyarm requested review from LeeDr, myasonik and rashmivkulkarni September 4, 2020 15:59

LeeDr reviewed Sep 4, 2020

View reviewed changes

x-pack/test/accessibility/apps/spaces.ts Outdated Show resolved Hide resolved

LeeDr reviewed Sep 4, 2020

View reviewed changes

x-pack/test/accessibility/apps/spaces.ts Show resolved Hide resolved

LeeDr reviewed Sep 4, 2020

View reviewed changes

x-pack/test/accessibility/apps/spaces.ts Outdated Show resolved Hide resolved

jportner approved these changes Sep 4, 2020

View reviewed changes

...ck/plugins/spaces/public/management/components/secure_space_message/secure_space_message.tsx Outdated Show resolved Hide resolved

x-pack/plugins/spaces/public/management/edit_space/enabled_features/feature_table.tsx Outdated Show resolved Hide resolved

bhavyarm and others added 2 commits September 4, 2020 12:39

Update x-pack/plugins/spaces/public/management/components/secure_spac…

4fde9a8

…e_message/secure_space_message.tsx Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

resolving review comments

2ed04c2

Merge branch 'a11ySpaces' of github.com:bhavyarm/kibana into a11ySpaces

26ef458

myasonik approved these changes Sep 4, 2020

View reviewed changes

LeeDr approved these changes Sep 4, 2020

View reviewed changes

bhavyarm added 2 commits September 4, 2020 17:06

Merge branch 'master' into a11ySpaces

3fb80ca

changes in describe to make sure tests are understandable

c816e75

elasticmachine and others added 2 commits September 8, 2020 07:03

Merge branch 'master' into a11ySpaces

40282fc

Merge branch 'master' into a11ySpaces

93946c5

Merge branch 'master' into a11ySpaces

6344792

bhavyarm added 3 commits September 8, 2020 13:07

Merge branch 'master' into a11ySpaces

f427c81

adding is Exists to reduce the nth element focus flakiness

1ba7924

Merge branch 'a11ySpaces' of github.com:bhavyarm/kibana into a11ySpaces

3791095

elasticmachine and others added 2 commits September 8, 2020 13:33

Merge branch 'master' into a11ySpaces

ced456b

test fix

5f6ae0c

Merge branch 'master' into a11ySpaces

6fbc899

bhavyarm merged commit 78f6410 into elastic:master Sep 9, 2020

bhavyarm mentioned this pull request Sep 9, 2020

[7.x] a11y tests on spaces home page including feature control (#76515) #77120

Merged

bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Sep 9, 2020

a11y tests on spaces home page including feature control (elastic#76515)

9f7c6a2

bhavyarm added a commit that referenced this pull request Sep 10, 2020

a11y tests on spaces home page including feature control (#76515) (#7…

d2a02a6

…7120)

bhavyarm added the v7.10.0 label Sep 29, 2020

bhavyarm mentioned this pull request Oct 1, 2020

[meta] Accessibility tests #51456

Closed

77 tasks

Conversation

bhavyarm commented Sep 2, 2020

Uh oh!

bhavyarm commented Sep 3, 2020

Uh oh!

bhavyarm commented Sep 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jportner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

myasonik left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

bhavyarm commented Sep 8, 2020

Uh oh!

bhavyarm commented Sep 8, 2020

Uh oh!

bhavyarm commented Sep 8, 2020

Uh oh!

bhavyarm commented Sep 8, 2020

Uh oh!

bhavyarm commented Sep 8, 2020

Uh oh!

bhavyarm commented Sep 9, 2020

Uh oh!

bhavyarm commented Sep 9, 2020

Uh oh!

kibanamachine commented Sep 9, 2020

💚 Build Succeeded

Build metrics

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants