[ENDPOINT] First version of the trusted apps list. by efreeti · Pull Request #76304 · elastic/kibana

efreeti · 2020-08-31T16:31:18Z

Summary

Trusted apps list page.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

...k/plugins/security_solution/public/management/pages/trusted_apps/state/async_data_binding.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/selectors.ts

paul-tavares

We should discuss this PR and the approach again.
Personally, I found the generics and approach to storing current/future views in state a bit confusing to the point I was really not clear what is going on.

x-pack/plugins/security_solution/public/management/common/routing.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/service/index.ts

...k/plugins/security_solution/public/management/pages/trusted_apps/state/async_data_binding.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/state/items_page.ts

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx

x-pack/plugins/security_solution/public/management/pages/trusted_apps/service/index.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/reducer.ts

… defaults.

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/selectors.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/middleware.ts

kevinlog · 2020-09-02T20:04:05Z

Thanks for making the changes!

From my POV, looks good to start writing tests against. Take a look at the failing tests regarding Endpoint list pagination.

https://github.com/elastic/kibana/pull/76304/checks?check_run_id=1063151680

I think think it may have to do with the way we're extracting the paging values from the URL. They should make their way to the Endpoint List state location object.

FYI @paul-tavares @parkiino

paul-tavares

Left some comments. They can be addressed in a subsequent PR - getting this through will enable concurrent work to go on in the UI ⭐
This most current version captures the common approaches that we been using, and with regards to the store state (bindings), we already discussed that renaming/adjusting those can come later.

Remember to Label your PR prior to moving it out of Draft and also add some prefixes to the PR title (I been using [SECURITY_SOLUTION][ENDPOINT], but I have seen other values.)

x-pack/plugins/security_solution/public/management/common/constants.ts

paul-tavares · 2020-09-02T20:15:07Z

x-pack/plugins/security_solution/public/management/pages/trusted_apps/service/index.ts

+import { HttpStart } from 'kibana/public';
+import { TRUSTED_APPS_LIST_API } from '../../../../../common/endpoint/constants';
+import {
+  GetTrustedListAppsResponse,


😳 I'll correct this. Should have been GetTrustedAppsListResponse

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/action.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/reducer.ts

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx

elasticmachine · 2020-09-08T12:42:16Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-09-08T12:42:42Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

…bala/trusted-apps-list

kibanamachine · 2020-09-08T14:39:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 944751d

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	1972	+10	1962

async chunks size

id	value	diff	baseline
securitySolution	10.0MB	+29.2KB	9.9MB

page load bundle size

id	value	diff	baseline
securitySolution	815.8KB	+2.9KB	812.9KB

History

💔 Build #73081 failed 2787e97
💚 Build #72313 succeeded 28c1b5d
💚 Build #72299 succeeded 865ff05
💔 Build #72287 failed c624cc7
💔 Build #72218 failed 7072df7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kevinlog

👍 lgtm, just want @paul-tavares to thumb as well

paul-tavares

👍
Had a few questions and suggestion, but non that would warrant delaying this merge.

x-pack/plugins/security_solution/public/management/common/constants.ts

x-pack/plugins/security_solution/public/management/common/routing.ts

x-pack/plugins/security_solution/public/management/pages/trusted_apps/test_utils/index.ts

...ugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.test.tsx

* First version of the trusted apps list. * Added proper visualisation of OS and Date Created columns. * Small change in naming in middleware. * Renamed function to avoid naming confusion. * Migrated to usage of selectors and memo in list component. * Added explicit return types. * Changed to use server schema for service parameter. * Removed some over generalisation in types. * Renamed types and properties related to trusted apps page state. * Renamed types and properties related to trusted apps page state. * Renamed the action type to be namespaced to trusted apps. * Merged the exports and declarations in reducer and used constants for defaults. * Memoization of pagination data structure. * Used a shared constant for REST API path. * Improvements and consistency on pagination across tabs. * Added a bit more typing and used Partial<> * Made constants readonly and added some useMemo usages. * Fixed extracting page index from URI. * Fixed the case of infinite refreshes when there is loading failure (need to rethink a bit conditions when to refresh). * Resetting state to initial when we navigate away from trusted apps list. * Fixed mapping page index to the table pagination. * Changed to using AppAction in reducer. * Made ServerApiError a default error type for data binding. * Renamed all types related to data binding to resource state. * Created index file for state types. * Fixed parameter extracting code to meet expectations of endpoints list behavior. * Updated snapshot. * Changed middleware to only use selectors. * Added tests for routing. * Added documentation to the types in async resource state module. * Added tests for async resource state module. * Added tests for store selectors. * Added tests for reducer. * Moved around imports. * Added tests for the middleware. * Added list component tests. * Removed a redundant function. * Commiting snapshots.

* master: (68 commits) a11y tests on spaces home page including feature control (elastic#76515) [ML] Transforms list: persist pagination through refresh interval (elastic#76786) [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876) [Timelion] Update timelion deprecation links (elastic#77008) [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928) Upgrade elastic charts to 21.1.2 (elastic#76939) [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778) [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861) Update saved object management UI text (elastic#76826) [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949) [Logs UI] Use fields api in log stream (elastic#76919) [UI Metrics] Support multi-colon keys (elastic#76913) [APM] Script for creating functional test archive (elastic#76926) [ENDPOINT] First version of the trusted apps list. (elastic#76304) Correct field for rum page url (elastic#76916) [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868) Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924) [RUM Dashboard] Visitor breakdown usability (elastic#76834) [Search] Add a new advanced setting searchTimeout (elastic#75728) [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959) ...

* First version of the trusted apps list. * Added proper visualisation of OS and Date Created columns. * Small change in naming in middleware. * Renamed function to avoid naming confusion. * Migrated to usage of selectors and memo in list component. * Added explicit return types. * Changed to use server schema for service parameter. * Removed some over generalisation in types. * Renamed types and properties related to trusted apps page state. * Renamed types and properties related to trusted apps page state. * Renamed the action type to be namespaced to trusted apps. * Merged the exports and declarations in reducer and used constants for defaults. * Memoization of pagination data structure. * Used a shared constant for REST API path. * Improvements and consistency on pagination across tabs. * Added a bit more typing and used Partial<> * Made constants readonly and added some useMemo usages. * Fixed extracting page index from URI. * Fixed the case of infinite refreshes when there is loading failure (need to rethink a bit conditions when to refresh). * Resetting state to initial when we navigate away from trusted apps list. * Fixed mapping page index to the table pagination. * Changed to using AppAction in reducer. * Made ServerApiError a default error type for data binding. * Renamed all types related to data binding to resource state. * Created index file for state types. * Fixed parameter extracting code to meet expectations of endpoints list behavior. * Updated snapshot. * Changed middleware to only use selectors. * Added tests for routing. * Added documentation to the types in async resource state module. * Added tests for async resource state module. * Added tests for store selectors. * Added tests for reducer. * Moved around imports. * Added tests for the middleware. * Added list component tests. * Removed a redundant function. * Commiting snapshots.

First version of the trusted apps list.

599a463

kevinlog reviewed Aug 31, 2020

View reviewed changes

...k/plugins/security_solution/public/management/pages/trusted_apps/state/async_data_binding.ts Outdated Show resolved Hide resolved

kevinlog reviewed Aug 31, 2020

View reviewed changes

...k/plugins/security_solution/public/management/pages/trusted_apps/state/async_data_binding.ts Outdated Show resolved Hide resolved

kevinlog reviewed Aug 31, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/selectors.ts Outdated Show resolved Hide resolved

paul-tavares reviewed Aug 31, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/trusted_apps/service/index.ts Outdated Show resolved Hide resolved

paul-tavares reviewed Sep 1, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/reducer.ts Outdated Show resolved Hide resolved

efreeti added 15 commits September 2, 2020 12:03

Added proper visualisation of OS and Date Created columns.

87766b0

Small change in naming in middleware.

97a6f41

Renamed function to avoid naming confusion.

29bedc8

Migrated to usage of selectors and memo in list component.

1ce8da6

Added explicit return types.

221ebc2

Changed to use server schema for service parameter.

96840cd

Removed some over generalisation in types.

caabfb9

Renamed types and properties related to trusted apps page state.

277b511

Renamed types and properties related to trusted apps page state.

223e14e

Renamed the action type to be namespaced to trusted apps.

0e6e1af

Merged the exports and declarations in reducer and used constants for…

d50f8fd

… defaults.

Memoization of pagination data structure.

bed5985

Used a shared constant for REST API path.

792a1a2

Improvements and consistency on pagination across tabs.

567e845

Added a bit more typing and used Partial<>

b2e581d

kevinlog reviewed Sep 2, 2020

View reviewed changes

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx Outdated Show resolved Hide resolved

kevinlog reviewed Sep 2, 2020

View reviewed changes

...ck/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.tsx Outdated Show resolved Hide resolved

kevinlog reviewed Sep 2, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/selectors.ts Show resolved Hide resolved

kevinlog reviewed Sep 2, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/middleware.ts Outdated Show resolved Hide resolved

paul-tavares reviewed Sep 2, 2020

View reviewed changes

efreeti added 2 commits September 3, 2020 12:35

Made constants readonly and added some useMemo usages.

f845f25

Fixed extracting page index from URI.

00417a7

efreeti added 8 commits September 4, 2020 11:03

Added documentation to the types in async resource state module.

0f05756

Added tests for async resource state module.

ecb90f3

Added tests for store selectors.

ec3e21f

Added tests for reducer.

0f07f06

Moved around imports.

99ea3a7

Added tests for the middleware.

cf6bd89

Added list component tests.

fa58f55

Removed a redundant function.

2787e97

efreeti marked this pull request as ready for review September 8, 2020 12:41

efreeti requested review from a team as code owners September 8, 2020 12:41

efreeti changed the title ~~First version of the trusted apps list.~~ [ENDPOINT] First version of the trusted apps list. Sep 8, 2020

efreeti added Team:Endpoint Management v7.10.0 v8.0.0 labels Sep 8, 2020

efreeti added the Feature:Endpoint Elastic Endpoint feature label Sep 8, 2020

efreeti added the release_note:skip Skip the PR/issue when compiling release notes label Sep 8, 2020

efreeti added 2 commits September 8, 2020 14:49

Commiting snapshots.

45debb2

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

944751d

…bala/trusted-apps-list

kevinlog approved these changes Sep 8, 2020

View reviewed changes

paul-tavares approved these changes Sep 8, 2020

View reviewed changes

efreeti merged commit 87380f5 into elastic:master Sep 9, 2020

efreeti deleted the btsymbala/trusted-apps-list branch September 9, 2020 09:43

efreeti mentioned this pull request Sep 9, 2020

[7.x] [ENDPOINT] First version of the trusted apps list. (#76304) #77063

Merged

Conversation

efreeti commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinlog commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paul-tavares Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 8, 2020

Uh oh!

elasticmachine commented Sep 8, 2020

Uh oh!

kibanamachine commented Sep 8, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

Uh oh!

kevinlog left a comment

Choose a reason for hiding this comment

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

efreeti commented Aug 31, 2020 •

edited

Loading

kevinlog commented Sep 2, 2020 •

edited

Loading