[Dashboard First] Lens Originating App Breadcrumb#75470
Merged
ThomThomson merged 12 commits intoelastic:masterfrom Aug 21, 2020
Merged
[Dashboard First] Lens Originating App Breadcrumb#75470ThomThomson merged 12 commits intoelastic:masterfrom
ThomThomson merged 12 commits intoelastic:masterfrom
Conversation
…ibana into feature/lensOriginatingAppBreadcrumb
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
…riginatingAppBreadcrumb
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Aug 21, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and works as expected, LGTM. That's a nice feature, thanks for adding it. I wonder whether we can even replace the Visualize breadcrumb with the current app instead of prepending.
Leaving that up to you though, I'm fine with both ways.
| core.application.navigateToApp(originatingApp); | ||
| }, | ||
| text: getAppNameFromId(originatingApp), | ||
| } as EuiBreadcrumb, |
Contributor
There was a problem hiding this comment.
Nit: This type cast doesn't seem necessary:
{
onClick: () => {
core.application.navigateToApp(originatingApp);
},
text: getAppNameFromId(originatingApp),
}
Contributor
Author
There was a problem hiding this comment.
Will fix this in the lens by value PR
Contributor
Author
|
That's a really good point, Joe. It could reinforce the 'dashboard first' project by not even providing a link to Visualize. I am considering changing it to:
in the Lens by Value PR |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 21, 2020
Changed lens breadcrumbs to reflect the Originating App
ThomThomson
added a commit
that referenced
this pull request
Aug 21, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 21, 2020
* master: (71 commits) [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772) Skip failing lens test Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074) Fix returned payload by "search" usage collector (elastic#75340) [Security Solution] Fix missing key error (elastic#75576) Upgrade EUI to v27.4.1 (elastic#75240) Update datasets UI copy to data streams (elastic#75618) [Lens] Register saved object references (elastic#74523) [DOCS] Update links to Beats documentation (elastic#70380) [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616) [Usage Collection Schemas] Remove Legacy entries (elastic#75652) [Dashboard First] Lens Originating App Breadcrumb (elastic#75470) Improve login UI error message. (elastic#75642) [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579) [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163) Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536) [Console] Get ES Config from core (elastic#75406) [Uptime] Add delay in telemetry test (elastic#75162) [Lens] Use index pattern service instead saved object client (elastic#74654) Embeddable input (elastic#73033) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the app title fetch method from #75457 to create a clickable breadcrumb in lens that will return the user to the originating app. This will work for every container!
Canvas
Dashboard
How to test this:
The new breadcrumb should show up any time you have created or edited a lens visualization from a container.
Checklist
Delete any items that are not applicable to this PR.
For maintainers