Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
spalger
reviewed
Aug 18, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Nice! Would you mind also deleting the setup/default_timeout.js file?
Contributor
|
Pinging @elastic/eui-design (EUI) |
spalger
approved these changes
Aug 18, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Operations: Jest config and version bumps LGTM
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
chandlerprall
approved these changes
Aug 18, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
package & snapshot changes LGTM
pgayvallet
approved these changes
Aug 18, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Only snapshot changes for platform owned files, LGTM.
cjcenizal
approved these changes
Aug 18, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Changes to the Snapshot and Restore test LGTM.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
poffdeluxe
reviewed
Aug 20, 2020
...ins/canvas/public/components/asset_manager/__stories__/__snapshots__/asset.stories.storyshot
Show resolved
Hide resolved
lizozom
approved these changes
Aug 20, 2020
shahzad31
approved these changes
Aug 20, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
Uptime changes LGTM !!
poffdeluxe
approved these changes
Aug 20, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Canvas changes look good to me!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Aug 21, 2020
* eui to 27.4.1 * src snapshot updates * x-pack snapshot updates * remove increased default timeout * revert date change * delete default_timeout file * reinstate storyshot Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 21, 2020
* master: (71 commits) [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772) Skip failing lens test Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074) Fix returned payload by "search" usage collector (elastic#75340) [Security Solution] Fix missing key error (elastic#75576) Upgrade EUI to v27.4.1 (elastic#75240) Update datasets UI copy to data streams (elastic#75618) [Lens] Register saved object references (elastic#74523) [DOCS] Update links to Beats documentation (elastic#70380) [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616) [Usage Collection Schemas] Remove Legacy entries (elastic#75652) [Dashboard First] Lens Originating App Breadcrumb (elastic#75470) Improve login UI error message. (elastic#75642) [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579) [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163) Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536) [Console] Get ES Config from core (elastic#75406) [Uptime] Add delay in telemetry test (elastic#75162) [Lens] Use index pattern service instead saved object client (elastic#74654) Embeddable input (elastic#73033) ...
thompsongl
added a commit
that referenced
this pull request
Aug 21, 2020
* Upgrade EUI to v27.4.1 (#75240) * eui to 27.4.1 * src snapshot updates * x-pack snapshot updates * remove increased default timeout * revert date change * delete default_timeout file * reinstate storyshot Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * merge resolution Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v27.4.0⏩v27.4.1Patch upgrade to resolve recent flakiness related to an updated dependency in EUI. EuiFocusTrap (used in modals and flyouts) was, in some cases, causing significant test run time increases resulting in timeout-based test failures.
The EUI patch introduces a global mock to alleviate the increase. Snapshot test output will not not show the DOM internals of EuiFocusTrap, but will instead result in a more shallow
<div data-eui="EuiFocusTrap" />.Example outcome on an affected test: 1.4s to 31ms time decrease, much more inline with other tests in the suite.
27.4.1testenvmock forEuiFocusTrap(#3930)