[Dashboard First] Use App Title for Display Instead of App Id#75457
Merged
ThomThomson merged 6 commits intoelastic:masterfrom Aug 20, 2020
Merged
[Dashboard First] Use App Title for Display Instead of App Id#75457ThomThomson merged 6 commits intoelastic:masterfrom
ThomThomson merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Aug 19, 2020
Contributor
majagrubic
left a comment
There was a problem hiding this comment.
Tested in Chrome on Mac OS X, works well!
9e6451b to
b5106b4
Compare
nreese
approved these changes
Aug 19, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
2 tasks
lukeelmers
approved these changes
Aug 19, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Code LGTM
nit - it would be nice if we could add a unit test for getAppNameFromId
d459355 to
59871e5
Compare
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 20, 2020
…c#75457) Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
ThomThomson
added a commit
that referenced
this pull request
Aug 21, 2020
#75580) Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2020
…c#75457) Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #75376
Added a method to fetch an app's title when given its id, to properly display a string for originating app anywhere it's needed. This PR also replaces instances where the raw id was displayed with the proper title.
For maintainers