[Ingest Pipelines] Processor forms for processors E-J by jloleysens · Pull Request #75054 · elastic/kibana

jloleysens · 2020-08-14T15:23:01Z

Summary

This contribution adds forms for the following processors:

Enrich
Fail
Foreach
GeoIP
Grok
Gsub
HTML strip
Inference
Join
JSON

How to test

Start Kibana with basic license
Go to ingest pipelines plugin in management section
Add a processor for each of the forms listed above (attempt to submit to see which fields are required)
Create the pipeline

Additional Context

Continuation of #72849

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

…ce processor form

- Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined.

…lizer bug

elasticmachine · 2020-08-14T15:23:03Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens · 2020-08-17T09:03:51Z

@elasticmachine merge upstream

jloleysens · 2020-08-18T11:19:07Z

@elasticmachine merge upstream

alisonelizabeth

Great job @jloleysens!

I left a few nits and copy suggestions in the code. I think it'd be helpful for the docs team to take a look at the copy as well.

I came across one bug - somewhat accidentally 😄 - when switching from the foreach processor, to a different processor, and then back again.

Also, as a future enhancement, I think it would be great if we could fetch a user's existing enrich policies for the enrich processor, and maybe point them to the enrich policy API docs if they don't have any.

alisonelizabeth · 2020-08-18T02:32:33Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx

+
+export const Fail: FunctionComponent = () => {
+  return (
+    <>


nit: is this fragment needed here?

alisonelizabeth · 2020-08-18T02:38:02Z

...ponents/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx

+      defaultMessage="Contains the inference type and its options. There are two types: {regression} and {classification}."
+      values={{
+        regression: (
+          <EuiLink


nit: there's an external prop that adds the external icon to the link

nice! did not know about this one.

alisonelizabeth · 2020-08-18T19:48:46Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      'xpack.ingestPipelines.pipelineEditor.enrichForm.overrideFieldHelpText',
+      {
+        defaultMessage:
+          'Whether this processor will update fields with pre-existing non-null-valued field. When set to false, such fields will not be overridden.',


Should this be "Whether this processor will update fields with a pre-existing non-null-valued field..."?

alisonelizabeth · 2020-08-18T19:49:32Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      'xpack.ingestPipelines.pipelineEditor.enrichForm.maxMatchesFieldHelpText',
+      {
+        defaultMessage:
+          'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object',


I think it would be helpful to include the maximum allowed value in the help text.

alisonelizabeth · 2020-08-18T19:50:06Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+          'xpack.ingestPipelines.pipelineEditor.enrichForm.fieldNameHelpText',
+          {
+            defaultMessage:
+              'The field in the input document that matches the policies match_field used to retrieve the enrichment data',


Suggested change

'The field in the input document that matches the policies match_field used to retrieve the enrichment data',

'The field in the input document that matches the policies match_field used to retrieve the enrichment data.',

alisonelizabeth · 2020-08-18T19:51:03Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx

+      defaultMessage: 'Message',
+    }),
+    helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.failForm.messageHelpText', {
+      defaultMessage: 'The error message thrown by the processor',


Suggested change

defaultMessage: 'The error message thrown by the processor',

defaultMessage: 'The error message thrown by the processor.',

alisonelizabeth · 2020-08-18T19:56:55Z

...ponents/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx

+        helpText={
+          <FormattedMessage
+            id="xpack.ingestPipelines.pipelineEditor.inferenceForm.targetFieldHelpText"
+            defaultMessage="Field added to incoming documents to contain results objects. Default value is {targetField}."


Is "results objects" correct here? I'm not sure I follow.

Yeah, some of these are a bit sketchy. I took most of these directly from the docs site, only lightly massaging to fit into context occasionally. These will definitely benefit from copy review.

alisonelizabeth · 2020-08-18T19:57:23Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx

+    helpText: i18n.translate(
+      'xpack.ingestPipelines.pipelineEditor.joinForm.separatorFieldHelpText',
+      {
+        defaultMessage: 'The separator character',


Suggested change

defaultMessage: 'The separator character',

defaultMessage: 'The separator character.',

alisonelizabeth · 2020-08-18T19:57:54Z

...onents/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx

+          'xpack.ingestPipelines.pipelineEditor.htmlStripForm.targetFieldHelpText',
+          {
+            defaultMessage:
+              'The field to assign the stripped value to. If blank the field will be updated in-place.',


Suggested change

'The field to assign the stripped value to. If blank the field will be updated in-place.',

'The field to assign the stripped value to. If blank, the field will be updated in-place.',

jloleysens · 2020-08-19T07:38:44Z

@elasticmachine merge upstream

jloleysens · 2020-08-19T16:04:43Z

Thanks for the review @alisonelizabeth ! I addressed your feedback. Do you think you could take another look? I was not able to reproduce the foreach editor bug, but I think it may have been fixed in this PR #75160.

Would you mind testing again now that I merged master? If the issue resurfaces I will take another look!

jrodewig

Phew! Thanks for putting this together @jloleysens.

Most of these look okay, but there are a few instances where the processor contains the wrong fields.

~~Not sure if it's related, but I had issues building this locally.~~ nvm. I just needed to clean my build.

I'd love to take another look once the missing/wrong fields are fixed. Thanks!

jrodewig · 2020-08-19T18:31:21Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      defaultMessage: 'Policy name',
+    }),
+    helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.enrichForm.policyNameHelpText', {
+      defaultMessage: 'The name of the enrich policy to use.',


Suggested change

defaultMessage: 'The name of the enrich policy to use.',

defaultMessage: 'Name of the enrich policy',

Can we add a link to https://www.elastic.co/guide/en/elasticsearch/reference/master/ingest-enriching-data.html here?

Unlike most of our other processors, enrich processors aren't really self-contained and require some setup before they can be used. I wouldn't assume a user is familiar with enrich policies and I don't think we can concisely explain it here.

Great point, will do!

jrodewig · 2020-08-19T18:34:09Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      'xpack.ingestPipelines.pipelineEditor.enrichForm.shapeRelationFieldHelpText',
+      {
+        defaultMessage:
+          'A spatial relation operator used to match the geo_shape of incoming documents to documents in the enrich index. This option is only used for geo_match enrich policy types.',


Suggested change

'A spatial relation operator used to match the geo_shape of incoming documents to documents in the enrich index. This option is only used for geo_match enrich policy types.',

'Operator used to match the geo-shape of incoming documents to enrich documents. Only used for geo-match enrich policies.',

If possible, I'd love to link to https://www.elastic.co/guide/en/elasticsearch/reference/current/enrich-policy-definition.html

geo-match policies are another complex topics users will likely need docs-context for.

jrodewig · 2020-08-19T18:54:38Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      'xpack.ingestPipelines.pipelineEditor.enrichForm.maxMatchesFieldHelpText',
+      {
+        defaultMessage:
+          'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object. Accepts numbers are 1 up to 128.',


Suggested change

'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object. Accepts numbers are 1 up to 128.',

'Number of matching enrich documents to include in the target field. Accepts 1–128.',

jrodewig · 2020-08-19T18:59:43Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+      'xpack.ingestPipelines.pipelineEditor.enrichForm.overrideFieldHelpText',
+      {
+        defaultMessage:
+          'Whether this processor will update fields with a pre-existing non-null-valued field. When set to false, such fields will not be overridden.',


Suggested change

'Whether this processor will update fields with a pre-existing non-null-valued field. When set to false, such fields will not be overridden.',

'If true, the processor can overwrite pre-existing field values.',

jrodewig · 2020-08-19T20:17:42Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+          'xpack.ingestPipelines.pipelineEditor.enrichForm.fieldNameHelpText',
+          {
+            defaultMessage:
+              'The field in the input document that matches the policy field used to retrieve the enrichment data.',


Suggested change

'The field in the input document that matches the policy field used to retrieve the enrichment data.',

'Field used to match incoming documents to enrich documents. Field values are compared to the match field set in the enrich policy.

jrodewig · 2020-08-19T21:12:20Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx

+    helpText: i18n.translate(
+      'xpack.ingestPipelines.pipelineEditor.joinForm.separatorFieldHelpText',
+      {
+        defaultMessage: 'The separator character.',


Suggested change

defaultMessage: 'The separator character.',

defaultMessage: 'Separator character',

jrodewig · 2020-08-19T21:13:21Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx

+      <FieldNameField
+        helpText={i18n.translate(
+          'xpack.ingestPipelines.pipelineEditor.joinForm.fieldNameHelpText',
+          { defaultMessage: 'The field to be separated.' }


Suggested change

{ defaultMessage: 'The field to be separated.' }

{ defaultMessage: 'Field containing array values to join' }

jrodewig · 2020-08-19T21:15:11Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx

+          'xpack.ingestPipelines.pipelineEditor.joinForm.targetFieldHelpText',
+          {
+            defaultMessage:
+              'The field to assign the joined value to. If empty, the field is updated in-place.',


Suggested change

'The field to assign the joined value to. If empty, the field is updated in-place.',

'Field used to contain the joined value. Defaults to {{original field}}.',

jrodewig · 2020-08-19T21:16:57Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx

+      'xpack.ingestPipelines.pipelineEditor.jsonForm.addToRootFieldHelpText',
+      {
+        defaultMessage:
+          'Inject the serialized JSON to the top level of the JSON document. A target field cannot be combined with this option.',


Suggested change

'Inject the serialized JSON to the top level of the JSON document. A target field cannot be combined with this option.',

'If true, add the JSON object to the top level of the document. Cannot be combined with a target field.',

jrodewig · 2020-08-19T21:17:40Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx

+      <FieldNameField
+        helpText={i18n.translate(
+          'xpack.ingestPipelines.pipelineEditor.joinForm.fieldNameHelpText',
+          { defaultMessage: 'The field to be separated.' }
+        )}
+      />
+
+      <TargetField />


This looks like a copy/paste error.

jrodewig · 2020-08-19T21:20:59Z

.../components/pipeline_processors_editor/components/manage_processor_form/processors/geoip.tsx

+    <>
+      <FieldNameField
+        helpText={i18n.translate(
+          'xpack.ingestPipelines.pipelineEditor.grokForm.fieldNameHelpText',


This ref looks wrong.

jrodewig · 2020-08-19T22:30:31Z

...ation/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx

  enrich: {
-    FieldsComponent: undefined, // TODO: Implement
+    FieldsComponent: Enrich,
    docLinkPath: '/enrich-processor.html',


Forgot to add this in my original review:

Unlike the other processors, the enrich processor is a bit complicated. I'd link to these docs rather than the processor docs:

Suggested change

docLinkPath: '/enrich-processor.html',

docLinkPath: '/ingest-enriching-data.html',

jloleysens · 2020-08-20T08:31:54Z

@elasticmachine merge upstream

…with horizontal rule

jloleysens · 2020-08-20T09:54:49Z

@jrodewig Thanks for the review!! I've addressed your feedback, would you mind taking another look?

jloleysens · 2020-08-20T11:07:07Z

@elasticmachine merge upstream

Stale review

jrodewig

I left a few bits of additional feedback for your review. Some of them are fixes to my earlier suggestions. 😬

Other notes:

The Grok and JSON processors have the wrong help text in them. Looks like a minor copy/paste error.
Where possible, I removed periods based on the EUI guidelines. My general heuristic is to not punctuate the text unless it A) is a full sentence or 2) contains two or more phrases. Let me know if that's not the norm for these.

I also think we need some help text for the commonly used Ignore missing field. I suggest:

Ignore documents with a missing field`.

Otherwise, this looks great! Thanks for putting this together!

jrodewig · 2020-08-20T13:16:39Z

.../components/pipeline_processors_editor/components/manage_processor_form/processors/geoip.tsx

+      'xpack.ingestPipelines.pipelineEditor.geoIPForm.firstOnlyFieldHelpText',
+      {
+        defaultMessage:
+          'If true, the first matching geo data is used, even if the field contains an array.',


Another fix to one of my earlier suggestions.

Suggested change

'If true, the first matching geo data is used, even if the field contains an array.',

'Use the first matching geo data, even if the field contains an array.',

jrodewig · 2020-08-20T13:16:42Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+    helpText: i18n.translate(
+      'xpack.ingestPipelines.pipelineEditor.enrichForm.overrideFieldHelpText',
+      {
+        defaultMessage: 'If true, the processor can overwrite pre-existing field values.',


This was my original suggestion, but true doesn't feel right here.

Suggested change

defaultMessage: 'If true, the processor can overwrite pre-existing field values.',

defaultMessage: 'If enabled, the processor can overwrite pre-existing field values.',

jrodewig · 2020-08-20T13:17:21Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/grok.tsx

+    helpText: i18n.translate(
+      'xpack.ingestPipelines.pipelineEditor.grokForm.traceMatchFieldHelpText',
+      {
+        defaultMessage: 'If true, include metadata about the matching expression in the document.',


A fix to one of my earlier suggestions.

Suggested change

defaultMessage: 'If true, include metadata about the matching expression in the document.',

defaultMessage: 'Add metadata about the matching expression to the document',

jrodewig · 2020-08-20T13:19:09Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx

+      defaultMessage: 'Message',
+    }),
+    helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.failForm.messageHelpText', {
+      defaultMessage: 'Error message returned by the processor.',


Period isn't needed.

Suggested change

defaultMessage: 'Error message returned by the processor.',

defaultMessage: 'Error message returned by the processor',

jrodewig · 2020-08-20T13:20:00Z

...omponents/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx

+      defaultMessage: 'Processor',
+    }),
+    helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.foreachForm.processorHelpText', {
+      defaultMessage: 'Ingest processor to run on each array value.',


Period isn't needed.

Suggested change

defaultMessage: 'Ingest processor to run on each array value.',

defaultMessage: 'Ingest processor to run on each array value',

jrodewig · 2020-08-20T13:30:41Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx

+      <FieldNameField
+        helpText={i18n.translate(
+          'xpack.ingestPipelines.pipelineEditor.jsonForm.fieldNameHelpText',
+          { defaultMessage: 'Field to be parsed.' }


Suggested change

{ defaultMessage: 'Field to be parsed.' }

{ defaultMessage: 'Field to be parsed' }

jrodewig · 2020-08-20T13:31:38Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx

+      'xpack.ingestPipelines.pipelineEditor.jsonForm.addToRootFieldHelpText',
+      {
+        defaultMessage:
+          'If true, add the JSON object to the top level of the document. Cannot be combined with a target field.',


Suggested change

'If true, add the JSON object to the top level of the document. Cannot be combined with a target field.',

'Add the JSON object to the top level of the document. Cannot be combined with a target field.',

jrodewig · 2020-08-20T13:33:13Z

...n/components/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx

+        )}
+      />
+
+      <TargetField />


The help text for this field is wrong:

Should be: Field used to contain the JSON object.

jrodewig · 2020-08-20T13:45:58Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+        helpText={i18n.translate(
+          'xpack.ingestPipelines.pipelineEditor.enrichForm.targetFieldHelpText',
+          {
+            defaultMessage: 'Field used to contain enrich data.',


Period isn't needed.

Suggested change

defaultMessage: 'Field used to contain enrich data.',

defaultMessage: 'Field used to contain enrich data',

jrodewig · 2020-08-20T13:46:16Z

...components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx

+          helpText: (
+            <FormattedMessage
+              id="xpack.ingestPipelines.pipelineEditor.enrichForm.policyNameHelpText"
+              defaultMessage="Name of the {enrichPolicyLink}."


Period isn't needed.

Suggested change

defaultMessage="Name of the {enrichPolicyLink}."

defaultMessage="Name of the {enrichPolicyLink}"

jloleysens · 2020-08-20T14:51:13Z

@jrodewig Thanks for the review! I assumed the period was needed, but happy to follow your/EUIs recommendation as that is what I thought I was doing 😅 - thanks for explaining, TIL! I'll implement your copy recommendations and merge.

kibanamachine · 2020-08-20T16:34:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 56642c2

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ingestPipelines	401	+11	390

async chunks size

id	value	diff	baseline
ingestPipelines	676.1KB	+32.7KB	643.4KB

History

💚 Build #69351 succeeded aea2c0b
💔 Build #69325 failed 4030a99
💛 Build #69304 was flaky 5718f77
💔 Build #69322 failed 1ad0f2e
💚 Build #69108 succeeded 6ecf830

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Added the enrich processor form (big one) * added fail processor form * Added foreach processor form * Added geoip processor form and refactored some deserialization * added grok processor form and updated comments and some i18n ids * updated existing gsub processor form to be in line with other forms * added html_strip processor form * refactored some serialize and deserialize functions and added inference processor form * fix copy-pasta mistake in inference form and add join processor form * Added JSON processor field - Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined. * remove unused variable * Refactor to use new shared target_field component, and fix JSON serializer bug * fix i18n * address pr feedback * Fix enrich max fields help text copy * add link to enrich policy docs in help text * fix error validation message in enrich policy form and replace space with horizontal rule * address copy feedback * fix i18n id typo * fix i18n * address additional round of feedback and fix json form help text Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Added the enrich processor form (big one) * added fail processor form * Added foreach processor form * Added geoip processor form and refactored some deserialization * added grok processor form and updated comments and some i18n ids * updated existing gsub processor form to be in line with other forms * added html_strip processor form * refactored some serialize and deserialize functions and added inference processor form * fix copy-pasta mistake in inference form and add join processor form * Added JSON processor field - Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined. * remove unused variable * Refactor to use new shared target_field component, and fix JSON serializer bug * fix i18n * address pr feedback * Fix enrich max fields help text copy * add link to enrich policy docs in help text * fix error validation message in enrich policy form and replace space with horizontal rule * address copy feedback * fix i18n id typo * fix i18n * address additional round of feedback and fix json form help text Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

jrodewig · 2020-08-21T18:27:32Z

@jrodewig I assumed the period was needed, but happy to follow your/EUIs recommendation...

Hey @jloleysens --- Just a follow-up: you were right!

@gchaps graciously reached out and corrected me here. We do end any field help text with periods. FWIW I think's that a good move for simplicity and consistency. I'll open up a follow-up PR (#75695) to re-add periods here. I'll also update the EUI guidelines so that rules are clear. I just wanted to let you know for future PRs.

Thanks for your patience as I learn the EUI ropes!

* Added the enrich processor form (big one) * added fail processor form * Added foreach processor form * Added geoip processor form and refactored some deserialization * added grok processor form and updated comments and some i18n ids * updated existing gsub processor form to be in line with other forms * added html_strip processor form * refactored some serialize and deserialize functions and added inference processor form * fix copy-pasta mistake in inference form and add join processor form * Added JSON processor field - Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined. * remove unused variable * Refactor to use new shared target_field component, and fix JSON serializer bug * fix i18n * address pr feedback * Fix enrich max fields help text copy * add link to enrich policy docs in help text * fix error validation message in enrich policy form and replace space with horizontal rule * address copy feedback * fix i18n id typo * fix i18n * address additional round of feedback and fix json form help text Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

jloleysens · 2020-08-24T07:47:57Z

@jrodewig No problem and thanks for getting back with this info!

jloleysens added 12 commits August 14, 2020 17:09

Added the enrich processor form (big one)

fa0e795

added fail processor form

3c9ad7a

Added foreach processor form

9ce24ce

Added geoip processor form and refactored some deserialization

02fbb2b

added grok processor form and updated comments and some i18n ids

b748cd8

updated existing gsub processor form to be in line with other forms

970939c

added html_strip processor form

1e12a63

refactored some serialize and deserialize functions and added inferen…

c4d39a0

…ce processor form

fix copy-pasta mistake in inference form and add join processor form

32b1d46

Added JSON processor field

13f37b4

- Also factored out target_field field to common field (still have to update the all instances) - Built out special logic for handling add_to_root and target_field combo on JSON processor form - Created another serializer, for default boolean -> undefined.

remove unused variable

cedbd88

Refactor to use new shared target_field component, and fix JSON seria…

ac6483e

…lizer bug

jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Aug 14, 2020

jloleysens requested a review from alisonelizabeth August 14, 2020 15:23

jloleysens requested a review from a team as a code owner August 14, 2020 15:23

fix i18n

0bbfab1

Merge branch 'master' into ingest-pipelines/processors-forms-ej

469d804

Merge branch 'master' into ingest-pipelines/processors-forms-ej

4592909

alisonelizabeth reviewed Aug 18, 2020

View reviewed changes

elasticmachine and others added 2 commits August 19, 2020 01:38

Merge branch 'master' into ingest-pipelines/processors-forms-ej

3e83391

address pr feedback

6ecf830

jrodewig self-requested a review August 19, 2020 16:40

jrodewig mentioned this pull request Aug 19, 2020

[Ingest Pipelines] Processor forms for processors A-D #72849

Merged

4 tasks

jrodewig previously requested changes Aug 19, 2020

View reviewed changes

jrodewig reviewed Aug 19, 2020

View reviewed changes

Fix enrich max fields help text copy

5718f77

elasticmachine and others added 4 commits August 20, 2020 02:32

Merge branch 'master' into ingest-pipelines/processors-forms-ej

e633d92

add link to enrich policy docs in help text

40be085

fix error validation message in enrich policy form and replace space …

70cc6f7

…with horizontal rule

address copy feedback

1ad0f2e

jloleysens added 2 commits August 20, 2020 12:01

fix i18n id typo

4030a99

fix i18n

721119d

Merge branch 'master' into ingest-pipelines/processors-forms-ej

aea2c0b

jrodewig approved these changes Aug 20, 2020

View reviewed changes

address additional round of feedback and fix json form help text

56642c2

jloleysens merged commit 644e9c2 into elastic:master Aug 20, 2020

jloleysens deleted the ingest-pipelines/processors-forms-ej branch August 20, 2020 17:04

This was referenced Aug 20, 2020

[7.x] [Ingest Pipelines] Processor forms for processors E-J (#75054) #75582

Merged

[Ingest Pipelines] Processor forms for processors K-S #75638

Merged

	'The field in the input document that matches the policies match_field used to retrieve the enrichment data',
	'The field in the input document that matches the policies match_field used to retrieve the enrichment data.',

	defaultMessage: 'The error message thrown by the processor',
	defaultMessage: 'The error message thrown by the processor.',

	defaultMessage: 'The separator character',
	defaultMessage: 'The separator character.',

	'The field to assign the stripped value to. If blank the field will be updated in-place.',
	'The field to assign the stripped value to. If blank, the field will be updated in-place.',

	defaultMessage: 'The name of the enrich policy to use.',
	defaultMessage: 'Name of the enrich policy',

	'A spatial relation operator used to match the geo_shape of incoming documents to documents in the enrich index. This option is only used for geo_match enrich policy types.',
	'Operator used to match the geo-shape of incoming documents to enrich documents. Only used for geo-match enrich policies.',

	'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object. Accepts numbers are 1 up to 128.',
	'Number of matching enrich documents to include in the target field. Accepts 1–128.',

	'Whether this processor will update fields with a pre-existing non-null-valued field. When set to false, such fields will not be overridden.',
	'If true, the processor can overwrite pre-existing field values.',

	'The field in the input document that matches the policy field used to retrieve the enrichment data.',
	'Field used to match incoming documents to enrich documents. Field values are compared to the match field set in the enrich policy.

	defaultMessage: 'The separator character.',
	defaultMessage: 'Separator character',

	{ defaultMessage: 'The field to be separated.' }
	{ defaultMessage: 'Field containing array values to join' }

	'The field to assign the joined value to. If empty, the field is updated in-place.',
	'Field used to contain the joined value. Defaults to {{original field}}.',

	'Inject the serialized JSON to the top level of the JSON document. A target field cannot be combined with this option.',
	'If true, add the JSON object to the top level of the document. Cannot be combined with a target field.',

	docLinkPath: '/enrich-processor.html',
	docLinkPath: '/ingest-enriching-data.html',

	'If true, the first matching geo data is used, even if the field contains an array.',
	'Use the first matching geo data, even if the field contains an array.',

	defaultMessage: 'If true, the processor can overwrite pre-existing field values.',
	defaultMessage: 'If enabled, the processor can overwrite pre-existing field values.',

	defaultMessage: 'If true, include metadata about the matching expression in the document.',
	defaultMessage: 'Add metadata about the matching expression to the document',

	defaultMessage: 'Error message returned by the processor.',
	defaultMessage: 'Error message returned by the processor',

	defaultMessage: 'Ingest processor to run on each array value.',
	defaultMessage: 'Ingest processor to run on each array value',

	{ defaultMessage: 'Field to be parsed.' }
	{ defaultMessage: 'Field to be parsed' }

Conversation

jloleysens commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Additional Context

Checklist

Uh oh!

elasticmachine commented Aug 14, 2020

Uh oh!

jloleysens commented Aug 17, 2020

Uh oh!

jloleysens commented Aug 18, 2020

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jloleysens commented Aug 19, 2020

Uh oh!

jloleysens commented Aug 19, 2020

Uh oh!

jrodewig left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrodewig Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrodewig Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jloleysens commented Aug 20, 2020

jloleysens commented Aug 14, 2020 •

edited

Loading

jrodewig left a comment •

edited

Loading

jrodewig Aug 19, 2020 •

edited

Loading

jrodewig Aug 19, 2020 •

edited

Loading

	'If true, add the JSON object to the top level of the document. Cannot be combined with a target field.',
	'Add the JSON object to the top level of the document. Cannot be combined with a target field.',

	defaultMessage: 'Field used to contain enrich data.',
	defaultMessage: 'Field used to contain enrich data',

	defaultMessage="Name of the {enrichPolicyLink}."
	defaultMessage="Name of the {enrichPolicyLink}"