Correct punctuation for ingest processors help text#75695
Merged
jrodewig merged 3 commits intoelastic:masterfrom Aug 25, 2020
jrodewig:ui__fix-ingest-proc-punct
Merged
Correct punctuation for ingest processors help text#75695jrodewig merged 3 commits intoelastic:masterfrom jrodewig:ui__fix-ingest-proc-punct
jrodewig merged 3 commits intoelastic:masterfrom
jrodewig:ui__fix-ingest-proc-punct
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
1 task
Contributor
Author
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Aug 25, 2020
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Changes look good!
Looks we are missing one more period here:
Contributor
Author
|
Thanks @jloleysens. Added with a5cc823 |
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome UI Functional Tests.test/functional/apps/visualize/_vega_chart·ts.visualize app vega chart in visualize app vega chart with filters should render different data in response to filter changeStandard OutStack TraceBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing periods (
.) to the field help text for the following processors:How to test
.)Checklist
Thank you! 🙇