Skip to content

Commit 6ecf830

Browse files
jloleysensjloleysens
committed
address pr feedback
1 parent 3e83391 commit 6ecf830

5 files changed

Lines changed: 10 additions & 12 deletions

File tree

‎x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const fieldsConfig: FieldsConfig = {
8989
'xpack.ingestPipelines.pipelineEditor.enrichForm.overrideFieldHelpText',
9090
{
9191
defaultMessage:
92-
'Whether this processor will update fields with pre-existing non-null-valued field. When set to false, such fields will not be overridden.',
92+
'Whether this processor will update fields with a pre-existing non-null-valued field. When set to false, such fields will not be overridden.',
9393
}
9494
),
9595
},
@@ -109,7 +109,7 @@ const fieldsConfig: FieldsConfig = {
109109
'xpack.ingestPipelines.pipelineEditor.enrichForm.maxMatchesFieldHelpText',
110110
{
111111
defaultMessage:
112-
'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object',
112+
'The maximum number of matched documents to include under the configured target field. The target_field will be turned into a json array if max_matches is higher than 1, otherwise target_field will become a json object. Accepts numbers are 1 up to 128.',
113113
}
114114
),
115115
validations: [
@@ -152,7 +152,7 @@ export const Enrich: FunctionComponent = () => {
152152
'xpack.ingestPipelines.pipelineEditor.enrichForm.fieldNameHelpText',
153153
{
154154
defaultMessage:
155-
'The field in the input document that matches the policies match_field used to retrieve the enrichment data',
155+
'The field in the input document that matches the policy field used to retrieve the enrichment data.',
156156
}
157157
)}
158158
/>

‎x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const fieldsConfig: FieldsConfig = {
2121
defaultMessage: 'Message',
2222
}),
2323
helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.failForm.messageHelpText', {
24-
defaultMessage: 'The error message thrown by the processor',
24+
defaultMessage: 'The error message thrown by the processor.',
2525
}),
2626
validations: [
2727
{
@@ -36,9 +36,5 @@ const fieldsConfig: FieldsConfig = {
3636
};
3737

3838
export const Fail: FunctionComponent = () => {
39-
return (
40-
<>
41-
<UseField component={Field} config={fieldsConfig.message} path="fields.message" />
42-
</>
43-
);
39+
return <UseField component={Field} config={fieldsConfig.message} path="fields.message" />;
4440
};

‎x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const HtmlStrip: FunctionComponent = () => {
2626
'xpack.ingestPipelines.pipelineEditor.htmlStripForm.targetFieldHelpText',
2727
{
2828
defaultMessage:
29-
'The field to assign the stripped value to. If blank the field will be updated in-place.',
29+
'The field to assign the stripped value to. If blank, the field will be updated in-place.',
3030
}
3131
)}
3232
/>

‎x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ const getInferenceConfigHelpText = (esDocsBasePath: string): React.ReactNode =>
5050
values={{
5151
regression: (
5252
<EuiLink
53+
external
5354
target="_blank"
5455
href={`${esDocsBasePath}/${INFERENCE_CONFIG_DOCS.regression.path}`}
5556
>
@@ -58,6 +59,7 @@ const getInferenceConfigHelpText = (esDocsBasePath: string): React.ReactNode =>
5859
),
5960
classification: (
6061
<EuiLink
62+
external
6163
target="_blank"
6264
href={`${esDocsBasePath}/${INFERENCE_CONFIG_DOCS.classification.path}`}
6365
>
@@ -164,7 +166,7 @@ export const Inference: FunctionComponent = () => {
164166
helpText={
165167
<FormattedMessage
166168
id="xpack.ingestPipelines.pipelineEditor.inferenceForm.targetFieldHelpText"
167-
defaultMessage="Field added to incoming documents to contain results objects. Default value is {targetField}."
169+
defaultMessage="Field added to incoming documents that will contain inference processor results. Default value is {targetField}."
168170
values={{ targetField: <EuiCode inline>{'ml.inference.<processor_tag>'}</EuiCode> }}
169171
/>
170172
}

‎x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const fieldsConfig: FieldsConfig = {
2626
helpText: i18n.translate(
2727
'xpack.ingestPipelines.pipelineEditor.joinForm.separatorFieldHelpText',
2828
{
29-
defaultMessage: 'The separator character',
29+
defaultMessage: 'The separator character.',
3030
}
3131
),
3232
validations: [

0 commit comments

Comments
 (0)