[SECURITY_SOLUTION] add z-index to get over nav bar#74427
Merged
kevinlog merged 1 commit intoelastic:masterfrom Aug 5, 2020
Merged
[SECURITY_SOLUTION] add z-index to get over nav bar#74427kevinlog merged 1 commit intoelastic:masterfrom
kevinlog merged 1 commit intoelastic:masterfrom
Conversation
pzl
approved these changes
Aug 5, 2020
Member
pzl
left a comment
There was a problem hiding this comment.
This seems fine for 7.9.
Maybe some before/after screenshots for the main PR comment would be nice
And we should file a backlog ticket for generalizing this for all flyouts on the page
paul-tavares
reviewed
Aug 5, 2020
| <EuiFlyout onClose={handleFlyoutClose} data-test-subj="hostDetailsFlyout" size="s"> | ||
| <EuiFlyout | ||
| onClose={handleFlyoutClose} | ||
| style={{ zIndex: 4001 }} |
aisantos
approved these changes
Aug 5, 2020
| <EuiFlyout onClose={handleFlyoutClose} data-test-subj="hostDetailsFlyout" size="s"> | ||
| <EuiFlyout | ||
| onClose={handleFlyoutClose} | ||
| style={{ zIndex: 4001 }} |
Contributor
💛 Build succeeded, but was flaky
Test FailuresPlugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration·js.task_manager scheduling and running tasks should return a task run error result when trying to run a task now which is already runningStandard OutStack TraceBuild metricsasync chunks size
To update your PR or re-run it, just comment with: |
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Aug 5, 2020
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Aug 5, 2020
kevinlog
added a commit
that referenced
this pull request
Aug 6, 2020
kevinlog
added a commit
that referenced
this pull request
Aug 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical issue where the nav bar was rendered in front of the Host flyout. This corrects that by added a greater z-index, similar to the timeline flyout.
BEFORE:

AFTER:

Checklist
Delete any items that are not applicable to this PR.
For maintainers