Skip to content

[ML] DF Analytics List: ensure empty prompt is consistent with overview#74174

Merged
alvarezmelissa87 merged 1 commit intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-list-empty
Aug 5, 2020
Merged

[ML] DF Analytics List: ensure empty prompt is consistent with overview#74174
alvarezmelissa87 merged 1 commit intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-list-empty

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 3, 2020

Summary

Fixes #73676

Updates analytics list empty prompt to be consistent with the overview page empty prompt for analytics.

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Aug 3, 2020
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 3, 2020 21:08
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 3, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
ml 4.3MB +50.0B 4.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Copy Markdown
Contributor Author

This is ready for a look when you get a chance cc @qn895, @walterra 🙏

@qn895
Copy link
Copy Markdown
Member

qn895 commented Aug 5, 2020

LGTM!

Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 4150a23 into elastic:master Aug 5, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Aug 5, 2020
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-list-empty branch August 5, 2020 16:59
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 6, 2020
* master: (208 commits)
  Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465)
  [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010)
  Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073)
  Filter out non-security jobs when collecting Detections telemetry (elastic#74456)
  [Security Solution][Test] Enzyme test for related events button (elastic#74411)
  [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427)
  Rename package configs SO to package policies (elastic#74422)
  [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762)
  skip flaky suite (elastic#71390)
  [ML] DF Analytics: adds functional tests for edit form (elastic#73885)
  Rename agent configs SO to agent policies (elastic#74397)
  [Jenkins] run CI when plugin readmes change (elastic#74388)
  [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311)
  fixing encoding issue with \ for enroll command (elastic#74379)
  [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341)
  Change experimental message for visualizations (elastic#74354)
  [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715)
  [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323)
  update empty prompt in analytics list (elastic#74174)
  [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Change text on DFA page when there is no job and replace link with button

5 participants