[Ingest Manager] Rename agent configs SO to agent policies#74397
Merged
jen-huang merged 1 commit intoelastic:masterfrom Aug 5, 2020
Merged
[Ingest Manager] Rename agent configs SO to agent policies#74397jen-huang merged 1 commit intoelastic:masterfrom
jen-huang merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
ruflin
approved these changes
Aug 5, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. @neptunian or @jfsiii could you also have a look?
jfsiii
approved these changes
Aug 5, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
The changes and plan SGTM
neptunian
approved these changes
Aug 5, 2020
Contributor
💚 Build SucceededBuild metricspage load bundle size
Saved Objects .kibana field count
To update your PR or re-run it, just comment with: |
This was referenced Aug 5, 2020
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Aug 5, 2020
# Conflicts: # x-pack/test/page_load_metrics/es_archives/default/mappings.json # x-pack/test/security_solution_cypress/es_archives/export_rule/mappings.json
jen-huang
added a commit
that referenced
this pull request
Aug 5, 2020
jen-huang
added a commit
that referenced
this pull request
Aug 5, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a proposal to rename
ingest-agent-configsSaved Object type toingest-agent-policiesahead of the rest of the work needed for renaming configs -> policies.The other work involved in the renaming effort requires more SO changes, but those changes can be handled by creating SO migrations. Per Platform team, changing the SO "type" string using a migration is theoretically possible, but may introduce a lot of complexity and unknowns. That's why I'd like to rename this string now to avoid potential breaking changes in a subsequent release.
This change is largely invisible to end users as we are not changing client routes, API routes, or UI yet. The only place where it surfaces is in the autocomplete for filtering agent configs, but I think this is acceptable for now: