[Discover] Context unskip date nanos functional tests#73781
Merged
kertal merged 3 commits intoelastic:masterfrom Jul 31, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
spalger
approved these changes
Jul 30, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
I don't see any issues, but I'm also not really qualified to review this 😅
dmlemeshko
approved these changes
Jul 30, 2020
Contributor
dmlemeshko
left a comment
There was a problem hiding this comment.
Great progress @kertal 👏
stratoula
approved these changes
Jul 31, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM, another test unskipped 🎉 As far as I can see the convertIsoToNanosAsStr is not used anywhere right now, you could potentially remove it (?)
Member
Author
Definitely! Thanks, removed it. |
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 31, 2020
* Use _source value of timestamp for search_after since ES allows this now * Unskip functional tests * Remove unused convertIsoToNanosAsStr # Conflicts: # src/plugins/discover/public/application/angular/context/api/utils/get_es_query_search_after.ts # test/functional/apps/context/_date_nanos_custom_timestamp.js
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 31, 2020
* master: (38 commits) [Discover] Context unskip date nanos functional tests (elastic#73781) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) ...
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kertal
added a commit
that referenced
this pull request
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unskips
date_nanosfunctional tests, and improves thesearch_aftersubmission to Elasticsearch fordate_nanos.It's now possible to use string formatted dates (elastic/elasticsearch#60328). The new solution is using this improvement, it's no longer a workaround 🥳. Furthermore it supports custom date time formats, so this tests now also work 🎂 . Due to 64bit integer value browser limitations the date_nanos value had to be built in a custom function and was submitted as a text value before (else it was automatically rounded by the browser).
Fixes #58815
Checklist
Delete any items that are not applicable to this PR.