[APM] Hide anomaly detection APM settings links when ml plugin is disabled#73638
Merged
ogupte merged 3 commits intoelastic:masterfrom Jul 30, 2020
Merged
Conversation
…the ml plugin is disabled.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
Author
|
retest |
Contributor
Author
|
@elasticmachine merge upstream |
smith
approved these changes
Jul 30, 2020
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jul 30, 2020
…the ml plugin is disabled. (elastic#73638) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jul 30, 2020
…the ml plugin is disabled. (elastic#73638) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx # x-pack/plugins/apm/public/components/app/Settings/index.tsx
| export function Home({ tab }: Props) { | ||
| const { config } = useApmPluginContext(); | ||
| const { config, core } = useApmPluginContext(); | ||
| const isMLEnabled = !!core.application.capabilities.ml; |
Member
There was a problem hiding this comment.
if ML is disabled in elasticsearch or disabled in the current space, this check will still be true.
I'd suggest looking for !!core.application.capabilities.ml?.canAccessML
canAccessML is the very minimum ML capability and is true on a basic license, so the current link to the start trial page will still work correctly.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 31, 2020
* master: (54 commits) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 31, 2020
* master: (38 commits) [Discover] Context unskip date nanos functional tests (elastic#73781) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) ...
ogupte
added a commit
that referenced
this pull request
Jul 31, 2020
…plugin is disabled. (#73638) (#73892) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx # x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx # x-pack/plugins/apm/public/components/app/Settings/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72914 by hiding anomaly detection settings links when the ml plugin is disabled.