[Discover] Improve saveSearch functional test handling#73626
Merged
kertal merged 3 commits intoelastic:masterfrom Jul 31, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dmlemeshko
reviewed
Jul 29, 2020
| await retry.waitFor(`saved search can be persisted name ${searchName}`, async () => { | ||
| await testSubjects.setValue('savedObjectTitle', searchName); | ||
| await testSubjects.click('confirmSaveSavedObjectButton'); | ||
| return (await header.isGlobalLoadingIndicatorVisible()) === true; |
Contributor
There was a problem hiding this comment.
I thought we might need to wait for popup to disappear
return (await testSubjects.exists('confirmSaveSavedObjectButton', { timeout: 5000 })) === false
Is there a chance that popup will remain in place and header.isGlobalLoadingIndicatorVisible() will return true ?
Member
Author
There was a problem hiding this comment.
good point 👍 , I will take a closer look here!
There was a problem hiding this comment.
I'm wondering if we can always catch the loading indicator after clicking save. Could it be that in some cases the save is quick enough that we never see the loading indicator?
Also, if we do find the loading indicator, I think we should then wait for it to be hidden before returning from saveSearch method. I think waitUntilLoadingHasFinished was doing that.
Member
Author
There was a problem hiding this comment.
I've changed the code to check for the save button not to be disabled, this should catch the occasional
flakiness when for whatever reason the title wasn't entered, and the save button stayed disabled therefore
Member
Author
There was a problem hiding this comment.
flaky test runner says, it's ok this way: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/712/
…-29-improve-discover-page-functional
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Jul 30, 2020
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - thanks for working on this! I didn't pull code and test. Only code review and Jenkins results.
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 31, 2020
* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 31, 2020
* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness
kertal
added a commit
that referenced
this pull request
Jul 31, 2020
kertal
added a commit
that referenced
this pull request
Jul 31, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 31, 2020
* master: (54 commits) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 31, 2020
* master: (38 commits) [Discover] Context unskip date nanos functional tests (elastic#73781) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve functional test
saveSearchmethod to prevent occasional flakiness, when a search name wasn't inserted and the persisting hasn't started therefore.Fixes #68706
https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/62931/console
Here's the flaky test runner to be sure, no errors reported:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/702/testReport/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_discover_reporting·ts/
Checklist