Skip to content

[Maps] fix tile layer attibution text and attribution link validation errors#73160

Merged
nreese merged 4 commits intoelastic:masterfrom
nreese:issue_72754
Jul 24, 2020
Merged

[Maps] fix tile layer attibution text and attribution link validation errors#73160
nreese merged 4 commits intoelastic:masterfrom
nreese:issue_72754

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jul 23, 2020

Fixes #72754 and #48269

Screen Shot 2020-07-23 at 4 16 13 PM

@nreese nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.10.0 v7.9.0 labels Jul 23, 2020
@nreese nreese requested a review from nickpeihl July 23, 2020 22:18
@nreese nreese requested a review from a team as a code owner July 23, 2020 22:18
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.8MB -102.0B 3.8MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 5f4b1a3 into elastic:master Jul 24, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 24, 2020
… errors (elastic#73160)

* [Maps] fix tile layer attibution text and attribution link validation errors

* clean up jest test

* tslint

* one more tslint
nreese added a commit to nreese/kibana that referenced this pull request Jul 24, 2020
… errors (elastic#73160)

* [Maps] fix tile layer attibution text and attribution link validation errors

* clean up jest test

* tslint

* one more tslint
nreese added a commit that referenced this pull request Jul 24, 2020
… errors (#73160) (#73174)

* [Maps] fix tile layer attibution text and attribution link validation errors

* clean up jest test

* tslint

* one more tslint
nreese added a commit that referenced this pull request Jul 24, 2020
… errors (#73160) (#73173)

* [Maps] fix tile layer attibution text and attribution link validation errors

* clean up jest test

* tslint

* one more tslint
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 27, 2020
* master: (111 commits)
  Remove flaky note from gauge tests (elastic#73240)
  Convert functional vega tests to ts and unskip tests (elastic#72238)
  [Graph] Unskip graph tests (elastic#72291)
  Add default Elasticsearch credentials to docs (elastic#72617)
  [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732)
  The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766)
  [KP] use new ES client in SO service (elastic#72289)
  [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995)
  Return EUI CSS to Shareable Runtime (elastic#72990)
  Removed useless karma test (elastic#73190)
  [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082)
  [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104)
  [Security Solution][Detections] Change detections breadcrumb title (elastic#73059)
  [ML] Fixing unnecessary deleting job polling (elastic#73087)
  [ML] Fixing recognizer wizard create job button (elastic#73025)
  [Composable template] Preview composite template (elastic#72598)
  [Uptime] Use manual intervals for ping histogram (elastic#72928)
  [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130)
  [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160)
  skip ingest pipeline api tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.9.0 v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] Tile Layer Attibution text and Attribution link validation errors

4 participants