Return EUI CSS to Shareable Runtime#72990
Merged
clintandrewhall merged 3 commits intoelastic:masterfrom Jul 24, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
|
@clintandrewhall I'm seeing this work properly when running the |
Contributor
Author
|
@corey I can test it again to be sure. Did you remember to build the runtime again? |
Contributor
|
@clintandrewhall Yep, did that multiple times to make sure I wasn't crazy. Maybe I still am though |
Contributor
Author
|
@elasticmachine merge upstream |
crob611
approved these changes
Jul 24, 2020
Contributor
crob611
left a comment
There was a problem hiding this comment.
That fixes it for me. Good find 👍
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 24, 2020
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jul 24, 2020
* Add Canvas Styles * Tree-shaking in EUI omits CSS in the runtime Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jul 24, 2020
* Add Canvas Styles * Tree-shaking in EUI omits CSS in the runtime Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
clintandrewhall
added a commit
that referenced
this pull request
Jul 25, 2020
clintandrewhall
added a commit
that referenced
this pull request
Jul 25, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 27, 2020
* master: (111 commits) Remove flaky note from gauge tests (elastic#73240) Convert functional vega tests to ts and unskip tests (elastic#72238) [Graph] Unskip graph tests (elastic#72291) Add default Elasticsearch credentials to docs (elastic#72617) [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732) The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766) [KP] use new ES client in SO service (elastic#72289) [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995) Return EUI CSS to Shareable Runtime (elastic#72990) Removed useless karma test (elastic#73190) [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082) [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104) [Security Solution][Detections] Change detections breadcrumb title (elastic#73059) [ML] Fixing unnecessary deleting job polling (elastic#73087) [ML] Fixing recognizer wizard create job button (elastic#73025) [Composable template] Preview composite template (elastic#72598) [Uptime] Use manual intervals for ping histogram (elastic#72928) [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130) [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160) skip ingest pipeline api tests ...
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #72967
As titled. EUI added tree shaking to the package, which allowed the Shareable Runtime build to remove it entirely.
To Test w/o Kibana:
canvas: node scripts/shareable_runtime --dev --run