Skip to content

[APM] Read body from indicesStats in upload-telemetry-data#72732

Merged
smith merged 3 commits intoelastic:masterfrom
smith:nls/indices-stats
Jul 26, 2020
Merged

[APM] Read body from indicesStats in upload-telemetry-data#72732
smith merged 3 commits intoelastic:masterfrom
smith:nls/indices-stats

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Jul 21, 2020

No description provided.

@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 21, 2020
@smith smith requested a review from a team July 21, 2020 20:12
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jul 21, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@sorenlouv
Copy link
Copy Markdown
Contributor

@smith Is it possible to create API tests or similar for this, so we can catch regressions like the one you just fixed?

@smith
Copy link
Copy Markdown
Contributor Author

smith commented Jul 26, 2020

@elasticmachine merge upstream

@smith
Copy link
Copy Markdown
Contributor Author

smith commented Jul 26, 2020

@smith Is it possible to create API tests or similar for this, so we can catch regressions like the one you just fixed?

I suppose we could set up something as part of the functional tests to run scripts in our scripts directory.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 55f55bf into elastic:master Jul 26, 2020
kibanamachine pushed a commit that referenced this pull request Jul 26, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

The PR was backported to the following branches:

smith added a commit to smith/kibana that referenced this pull request Jul 26, 2020
@smith smith deleted the nls/indices-stats branch July 26, 2020 18:21
smith added a commit that referenced this pull request Jul 26, 2020
…73230)

add for transport request too

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
smith added a commit that referenced this pull request Jul 27, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 27, 2020
* master: (111 commits)
  Remove flaky note from gauge tests (elastic#73240)
  Convert functional vega tests to ts and unskip tests (elastic#72238)
  [Graph] Unskip graph tests (elastic#72291)
  Add default Elasticsearch credentials to docs (elastic#72617)
  [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732)
  The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766)
  [KP] use new ES client in SO service (elastic#72289)
  [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995)
  Return EUI CSS to Shareable Runtime (elastic#72990)
  Removed useless karma test (elastic#73190)
  [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082)
  [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104)
  [Security Solution][Detections] Change detections breadcrumb title (elastic#73059)
  [ML] Fixing unnecessary deleting job polling (elastic#73087)
  [ML] Fixing recognizer wizard create job button (elastic#73025)
  [Composable template] Preview composite template (elastic#72598)
  [Uptime] Use manual intervals for ping histogram (elastic#72928)
  [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130)
  [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160)
  skip ingest pipeline api tests
  ...
@smith
Copy link
Copy Markdown
Contributor Author

smith commented Jul 27, 2020

@smith Is it possible to create API tests or similar for this, so we can catch regressions like the one you just fixed?

Created #73278 to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants