[Uptime] Fix accessibility issue in Uptime app nav links#72926
Merged
justinkambic merged 3 commits intoelastic:masterfrom Jul 22, 2020
Merged
[Uptime] Fix accessibility issue in Uptime app nav links#72926justinkambic merged 3 commits intoelastic:masterfrom
justinkambic merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
myasonik
approved these changes
Jul 22, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
Ran it locally and everything seems to work! Thanks for the quick turnaround on this!
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jul 22, 2020
* Fix accessibility issue in Uptime app nav links. * Refresh outdated snapshot. * Introduce aria-label for hidden content.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jul 22, 2020
* Fix accessibility issue in Uptime app nav links. * Refresh outdated snapshot. * Introduce aria-label for hidden content.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 23, 2020
* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...
justinkambic
added a commit
that referenced
this pull request
Jul 23, 2020
justinkambic
added a commit
that referenced
this pull request
Jul 23, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71165.
We had a number of cases where navigation links were utilizing React Router's
Linkcomponent, and nesting anEuiButton. This caused the rendered HTML to nest abuttonelement inside anatag.To work around this, I followed the EUI team's recommendations for integrating with React Router 5.1+ and utilize the useHistory hook to create
hrefvalues which I then provided toEuiButton. When this prop is provided,EuiButtonwill render anatag; this should cause us to preserve all functionality while removing the unnecessary button, with no impact to the page styling.Testing this PR
To test this PR, ensure that all of the links noted in the issue are still working.
Checklist
Delete any items that are not applicable to this PR.
For maintainers