[Lens] Fix inconsistencies when switching with empty layer#72809
Merged
flash1293 merged 1 commit intoelastic:masterfrom Jul 23, 2020
Merged
[Lens] Fix inconsistencies when switching with empty layer#72809flash1293 merged 1 commit intoelastic:masterfrom
flash1293 merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Jul 22, 2020
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
Tested with Safari, works as expected. Code LGTM 👌
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 23, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 23, 2020
* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Aug 17, 2020
This was referenced Aug 17, 2020
mbondyra
added a commit
that referenced
this pull request
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72749
This PR fixes the behavior of Lens when switching the chart using the chart switcher without any data configured. It also improves the behavior when dragging in a field.
The following changes were made:
initializeroutine from creating an unnecessary layer, instead the existing empty one is simply reused https://github.com/elastic/kibana/pull/72809/files#diff-d1d4dfa90d8f9d84296810bf9a3ee522R163-R166initial(created from scratch). This allows Lens to configure the chart type before the first field is dragged. Before this change, changing to Line and dragging in the "Records" field would switch back to stacked bar. Note that when the table is using an ordinal scale on the x axis column, the already selected series type will not be respected if it's line or area based. https://github.com/elastic/kibana/pull/72809/files#diff-e4fd356362a87d0bb42766a35c2bcc5bL321-R321