[Security Solution][Exceptions] - Update UI exceptions builder nested logic#72490
Merged
yctercero merged 23 commits intoelastic:masterfrom Jul 22, 2020
Merged
[Security Solution][Exceptions] - Update UI exceptions builder nested logic#72490yctercero merged 23 commits intoelastic:masterfrom
yctercero merged 23 commits intoelastic:masterfrom
Conversation
…ll checking signals index for closing alerts functionality
yctercero
commented
Jul 22, 2020
| * @param entries an ExceptionItem's entries | ||
| * @param item a single ExceptionItem entry | ||
| */ | ||
| export const getFormattedEntries = (entries: BuilderEntry[]): FormattedEntry[] => { |
Contributor
Author
There was a problem hiding this comment.
These big chunks that appear as removed were just moved into builder/helper.ts since they weren't shared utils, just applied to the builder. Was trying to cleanup as this file is getting large.
yctercero
commented
Jul 22, 2020
| padding-top: 20px; | ||
| `; | ||
|
|
||
| const MyBeautifulLine = styled(EuiFlexItem)` |
Contributor
Author
There was a problem hiding this comment.
Happy to remain, my creativity was running low...
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
yctercero
commented
Jul 22, 2020
| }, | ||
| entryIndex | ||
| ); | ||
| if (entry.nested === 'parent') { |
Contributor
Author
There was a problem hiding this comment.
Want to follow up moving all this logic out to easily testable helpers.
FrankHassanabad
approved these changes
Jul 22, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
LGTM! Wow, you really did us all so many favors this release with all these features and nested.
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Jul 22, 2020
… logic (elastic#72490) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](elastic#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Jul 22, 2020
… logic (elastic#72490) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](elastic#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
yctercero
added a commit
that referenced
this pull request
Jul 23, 2020
… logic (#72490) (#72982) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
yctercero
added a commit
that referenced
this pull request
Jul 23, 2020
… logic (#72490) (#72983) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 23, 2020
* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🥁 This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it here and here. It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
exceptions/helpers.tsxfile into separate helper files under the corresponding components (builder or viewer) where there wasn't any overlaponClickto add/edit exceptions modal mask overlay so that user does not need to refresh page if modal hits an issuebuilder_button_options.tsxto now expose theAdd nested fieldto UIAdd nested fieldis available at all times - it can be disabled if need be by the consumer of the exceptions builderAdd nested field, a new empty entry is shown that limits the fields to only nested types that match the parent andOris disabledAdd, another entry, still under the nested parent is addedAdd non nested fieldand it returns them to the normal flowDeletenext to the parent entry, deletes the entire nested entry and childrenDelete, an empty entry, similar to the one shown on init is displayedNote: Double checked with @marrasherrier on the design. The initial designs limited the user to adding one nested field as the last item. This allows a user to add multiple nested fields and non-nested fields.
Samples 🤤
Close modal when overlay mask clicked
Allow user to delete field selection with delete key
If user deletes last item, goest back to empty default
Adding a nested entry
Deleting nested entry
Sample
and,or,nestedTo Do
builder/entry_item.tsxAdd nested--> then selectsAdd non nestedwithout having selected any nested fieldChecklist
Delete any items that are not applicable to this PR.