[Maps] 7.9 design improvements#71563
Merged
elizabetdev merged 8 commits intoelastic:masterfrom Jul 14, 2020
Merged
Conversation
nreese
reviewed
Jul 14, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Looks like there are some jest snapshots that will need to be updated
...plugins/maps/public/connected_components/add_layer_panel/flyout_body/layer_wizard_select.tsx
Outdated
Show resolved
Hide resolved
| <EuiFlexItem key={layerWizard.title}> | ||
| <EuiCard | ||
| title={layerWizard.title} | ||
| titleSize="xs" |
Contributor
There was a problem hiding this comment.
Thanks. the smaller titles look much better
Contributor
Author
|
@elasticmachine merge upstream |
nreese
reviewed
Jul 14, 2020
x-pack/plugins/maps/public/connected_components/layer_panel/join_editor/resources/join.js
Outdated
Show resolved
Hide resolved
…u/kibana into maps-design-improvements
cchaos
approved these changes
Jul 14, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 Code looks good from the design side
nreese
approved these changes
Jul 14, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this design fixes
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
elizabetdev
added a commit
that referenced
this pull request
Jul 14, 2020
* Design improvements * more improvements * Updated snapshots * Removing unecessary flex item * Updated snapshot * Addressing pr review Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a few design improvements.
A gutter space was missing between the EuiColorPalettePicker and the as number select box. I left a comment on #69190 and requested changes but the comment was missed (#69190 (review)). So I'm adding the missing gutter space.
For consistency, I changed the add join button to look similar to the others add buttons.
There was a horizontal scrollbar caused by the horizontal EuiFacetGroup. The issue was fixed by adding a smaller
gutterSize. I also decreased the size of the titles.I also found this small issue. A EuiPanel inside a EuiPanel. I removed the EuiPanel and I made sure the EMS Basemaps add layer is not missing the EuiPanel.
Checklist
Delete any items that are not applicable to this PR.