[Observability] landing page always being displayed#71494
Merged
cauemarcondes merged 5 commits intoelastic:masterfrom Jul 14, 2020
Merged
[Observability] landing page always being displayed#71494cauemarcondes merged 5 commits intoelastic:masterfrom
cauemarcondes merged 5 commits intoelastic:masterfrom
Conversation
kindsun
approved these changes
Jul 13, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Maps changes lgtm w/ green CI!
- code review
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Jul 14, 2020
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
Observability change lgtm. Let's double check that the modifications to the tests are ok.
poffdeluxe
approved these changes
Jul 14, 2020
Contributor
💚 Backport successfulThe PR was backported to the following branches:
|
sorenlouv
pushed a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 14, 2020
* hides overview item when no other obs plugin is available. * reverting tests changes * reverting tests changes * adding overview to observability tests
Contributor
|
Thanks for fixing this, y'all!!! |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
cauemarcondes
added a commit
that referenced
this pull request
Jul 14, 2020
* hides overview item when no other obs plugin is available. * reverting tests changes * reverting tests changes * adding overview to observability tests Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
This was referenced Jul 14, 2020
pgayvallet
reviewed
Sep 16, 2020
Comment on lines
+12
to
+14
| if (!someVisible) { | ||
| core.chrome.navLinks.update('observability-overview', { hidden: true }); | ||
| } |
Contributor
There was a problem hiding this comment.
Quite late, but note that this is a deprecated API:
kibana/src/core/public/chrome/nav_links/nav_links_service.ts
Lines 76 to 82 in bf04235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #68908
Reverting test changes that shouldn't have been made here 0d5b98d