[ML] Anomaly swim lane embeddable navigation and filter actions by darnautov · Pull Request #71082 · elastic/kibana

darnautov · 2020-07-08T13:09:14Z

Summary

Related meta issue #66553.

Introduces the following swim lane embeddable actions:

Open swim lane in the Anomaly Explorer preserving pagination. Supports both executions from the embeddable panel context menu and cell selection trigger
Apply the selected time range to the dashboard. In case a single cell has been clicked it uses the interval to populate the time range.
Add filters with selected influencer values. Affect all the other visualizations on the dashboard.

ML URL Generator (#69265)

ML URL generator has been introduced to produce URLs to the Anomaly Explorer page.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

elasticmachine · 2020-07-09T13:23:41Z

Pinging @elastic/ml-ui (:ml)

…e-drilldown

x-pack/plugins/ml/public/ui_actions/apply_influencer_filters_action.tsx

peteharverson · 2020-07-13T11:02:45Z

x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_embeddable.tsx

      {
-        jobIds: initialInput.jobIds,
-        swimlaneType: initialInput.swimlaneType,
        defaultTitle: initialInput.title,


I don't seem to be able to edit the embeddable panel title, when I add a new embeddable, or edit an existing one. Do you see the same?

I'm able to edit the title, but there was an issue with a swim lane initializer. Fixed in 5c39b47

I can edit it now, but only by keyboard navigation into the text box. But this affects all the visualizations on my dashboard; not just the swim lane embeddable.

You might need to run yarn kbn clean and re-bootstrap. Changing the title works for me for all panels on the dashboard.

x-pack/plugins/ml/public/ui_actions/apply_influencer_filters_action.tsx

x-pack/plugins/ml/public/ui_actions/open_in_anomaly_explorer_action.tsx

x-pack/plugins/ml/public/application/components/job_selector/use_job_selection.ts

x-pack/plugins/ml/public/application/explorer/explorer_swimlane.tsx

alvarezmelissa87

Code LGTM ⚡

…e-drilldown

qn895 · 2020-07-14T13:35:31Z

Code LGTM.

peteharverson

Tested latest edits and LGTM!

kibanamachine · 2020-07-14T14:17:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f69688d

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ml	389	+2	387

History

💚 Build #61298 succeeded 5fa4baf
💛 Build #60920 was flaky 90d8379
💔 Build #60853 failed 9693776
💔 Build #60773 failed 3f83427
💔 Build #60622 failed e6c487e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…tic#71082) * [ML] dragSelect as part of ExplorerSwimlane component * [ML] use wrapper ref * [ML] rename callback * [ML] WIP open in anomaly explorer * [ML] MlUrlGenerator unit tests * [ML] WIP actions * [ML] restore pagination * [ML] fix fromPage on initial load * [ML] fix cell selection, filter and time range actions * [ML] update url generator params * [ML] prevent label text selection on drag select * [ML] fix types and unit tests * [ML] fix embeddable init * [ML] fix swim lane unit tests * [ML] change action label, use filter action only for single cell click * [ML] fix time range bounds * [ML] fix TS issues * [ML] fix pagination persistence * [ML] use viewByFrom the embeddable input

* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...

…) (#71648) * [ML] dragSelect as part of ExplorerSwimlane component * [ML] use wrapper ref * [ML] rename callback * [ML] WIP open in anomaly explorer * [ML] MlUrlGenerator unit tests * [ML] WIP actions * [ML] restore pagination * [ML] fix fromPage on initial load * [ML] fix cell selection, filter and time range actions * [ML] update url generator params * [ML] prevent label text selection on drag select * [ML] fix types and unit tests * [ML] fix embeddable init * [ML] fix swim lane unit tests * [ML] change action label, use filter action only for single cell click * [ML] fix time range bounds * [ML] fix TS issues * [ML] fix pagination persistence * [ML] use viewByFrom the embeddable input

darnautov added 9 commits July 9, 2020 14:46

[ML] dragSelect as part of ExplorerSwimlane component

7a1c652

[ML] use wrapper ref

2179b30

[ML] rename callback

5b2a07e

[ML] WIP open in anomaly explorer

52807cc

[ML] MlUrlGenerator unit tests

19a78c0

[ML] WIP actions

293a9f1

[ML] restore pagination

63bba93

[ML] fix fromPage on initial load

3359c84

[ML] fix cell selection, filter and time range actions

ec75f9f

darnautov force-pushed the ML-66553-swim-lane-drilldown branch from 703d1d5 to ec75f9f Compare July 9, 2020 12:47

darnautov self-assigned this Jul 9, 2020

darnautov mentioned this pull request Jul 9, 2020

[ML] Embeddables enhancements #66553

Open

10 tasks

elastic deleted a comment from kibanamachine Jul 9, 2020

darnautov requested review from alvarezmelissa87, peteharverson and qn895 July 9, 2020 13:22

darnautov added :ml Feature:Embedding Embedding content via iFrame Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:enhancement v7.9.0 v8.0.0 and removed Feature:Embedding Embedding content via iFrame labels Jul 9, 2020

darnautov marked this pull request as ready for review July 9, 2020 13:23

darnautov requested a review from a team as a code owner July 9, 2020 13:23

darnautov added the Feature:Anomaly Detection ML anomaly detection label Jul 9, 2020

darnautov added 3 commits July 9, 2020 15:49

[ML] update url generator params

666dfbb

[ML] prevent label text selection on drag select

e6c487e

[ML] fix types and unit tests

1d41ab3

Merge remote-tracking branch 'upstream/master' into ML-66553-swim-lan…

3f83427

…e-drilldown

peteharverson reviewed Jul 13, 2020

View reviewed changes

x-pack/plugins/ml/public/ui_actions/apply_influencer_filters_action.tsx Show resolved Hide resolved

peteharverson reviewed Jul 13, 2020

View reviewed changes

x-pack/plugins/ml/public/ui_actions/apply_influencer_filters_action.tsx Outdated Show resolved Hide resolved

peteharverson reviewed Jul 13, 2020

View reviewed changes

x-pack/plugins/ml/public/ui_actions/open_in_anomaly_explorer_action.tsx Show resolved Hide resolved

darnautov added 3 commits July 13, 2020 14:30

[ML] fix embeddable init

5c39b47

[ML] fix swim lane unit tests

9f1acdc

[ML] change action label, use filter action only for single cell click

9693776

darnautov requested a review from peteharverson July 13, 2020 14:10

darnautov added 2 commits July 13, 2020 17:04

[ML] fix time range bounds

98bd9b2

[ML] fix TS issues

90d8379

alvarezmelissa87 reviewed Jul 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/components/job_selector/use_job_selection.ts Outdated Show resolved Hide resolved

alvarezmelissa87 reviewed Jul 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer_swimlane.tsx Show resolved Hide resolved

alvarezmelissa87 approved these changes Jul 13, 2020

View reviewed changes

darnautov added 3 commits July 14, 2020 12:22

[ML] fix pagination persistence

5fa4baf

[ML] use viewByFrom the embeddable input

d0b1b82

Merge remote-tracking branch 'upstream/master' into ML-66553-swim-lan…

f69688d

…e-drilldown

qn895 approved these changes Jul 14, 2020

View reviewed changes

peteharverson approved these changes Jul 14, 2020

View reviewed changes

darnautov merged commit 50f8db7 into elastic:master Jul 14, 2020

darnautov deleted the ML-66553-swim-lane-drilldown branch July 14, 2020 14:17

darnautov mentioned this pull request Jul 14, 2020

[7.x] [ML] Anomaly swim lane embeddable navigation and filter actions (#71082) #71648

Merged

peteharverson mentioned this pull request Jul 16, 2020

[ML] Url generator #69265

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Anomaly swim lane embeddable navigation and filter actions#71082

[ML] Anomaly swim lane embeddable navigation and filter actions#71082
darnautov merged 21 commits intoelastic:masterfrom
darnautov:ML-66553-swim-lane-drilldown

darnautov commented Jul 8, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jul 9, 2020

Uh oh!

Uh oh!

peteharverson Jul 13, 2020

Uh oh!

darnautov Jul 13, 2020

Uh oh!

peteharverson Jul 13, 2020

Uh oh!

darnautov Jul 14, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alvarezmelissa87 left a comment

Uh oh!

qn895 commented Jul 14, 2020

Uh oh!

peteharverson left a comment

Uh oh!

kibanamachine commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

darnautov commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Introduces the following swim lane embeddable actions:

ML URL Generator (#69265)

Checklist

Uh oh!

elasticmachine commented Jul 9, 2020

Uh oh!

Uh oh!

peteharverson Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

darnautov Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

peteharverson Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

darnautov Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 commented Jul 14, 2020

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

darnautov commented Jul 8, 2020 •

edited

Loading