[EPM] Use higher priority than default templates#70640
Merged
jonathan-buttner merged 2 commits intoelastic:masterfrom Jul 2, 2020
Merged
[EPM] Use higher priority than default templates#70640jonathan-buttner merged 2 commits intoelastic:masterfrom
jonathan-buttner merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Feature:EPM) |
ph
approved these changes
Jul 2, 2020
nchaulet
approved these changes
Jul 2, 2020
ruflin
approved these changes
Jul 2, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Jul 2, 2020
* Use higher priority than default templates * Fixing the jest tests
Contributor
Author
|
@ph does this need to be backported to 7.8? I'm not sure what we had as the priority for the |
jonathan-buttner
added a commit
that referenced
this pull request
Jul 3, 2020
Contributor
|
@jonathan-buttner I don't think this needs backporting as the assets from Elasticsearch were not in 7.8. Or was it also a problem with just the base package? |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (32 commits) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) [kbn/optimizer] only build specified themes (elastic#70389) Fix saved query modal overlay (elastic#68826) Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633) [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634) fix 400 error on initial signals search (elastic#70618) [Maps] fix unable to edit heatmap metric (elastic#70606) Update network idle timeout (elastic#70629) [APM] Disable flaky useFetcher test (elastic#70638) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (199 commits) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) ...
Contributor
Author
Oh you're right, the base package had priority So we don't need to backport to 7.8 👍 |
Contributor
|
no need for 7.8, they don't ship assert by default with ES. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets the templates that the ingest manager creates to be higher priority than the default ES
logsandmetricstemplates (100)elastic/elasticsearch#57629 (comment)