[Canvas] Handle timeouts on creating templates#70635
Merged
crob611 merged 3 commits intoelastic:masterfrom Jul 3, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
poffdeluxe
approved these changes
Jul 2, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
I didn't test it out but code looks good. Small question about the logging (If there's an easy way to do it, it might be helpful... just so it doesn't fail silently and someone who wants the pitch template is left wondering why it isn't there)
| // creates and catch and throw-away any errors that happen. | ||
| // Once packages are ready, we should probably move that pitch that is so large to a package | ||
| for (const template of templates) { | ||
| client.create(TEMPLATE_TYPE, template, { id: template.id }).catch((err) => undefined); |
Contributor
There was a problem hiding this comment.
Is there any debug logging maybe we could do here that'd be appropriate? Just in case a dev does expect that template to get loaded
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (199 commits) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: [Lens] Fitting functions (elastic#69820) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648)
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jul 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
crob611
pushed a commit
that referenced
this pull request
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pitch presentation causes problems again!
After merging the Templates -> SavedObjects PR, some devs were hitting an issue if using kibana vs a remote ES instance. The pitch presentation is so large, it was timing out which was causing an unhandled rejection when kibana was starting up.
To fix, instead of bulk creating all of the templates, we fire off individual requests to create them, and then ignore any requests that fail. The hope here is that even if the pitch fails, that the other ones will succeed and there will be some templates.
Once the package manager is fully up and running, we should probably pull the pitch presentation out of kibana and move it to the package repo.
Also fixed a few type errors around the template component.