Fix saved query modal overlay#68826
Conversation
cchaos
left a comment
There was a problem hiding this comment.
I'm not sure I can be of much help here, but it seems appropriate to close the popover when the modal is opened.
|
Pinging @elastic/siem (Team:SIEM) |
|
Thanks for picking this one up @patrykkopycinski! 😀 Here's a related issue regarding the save query modal's z-index: #48124 And I agree with @cchaos that we should close the popover when the modal is open. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elastic/kibana-app-arch can I ask you take a look at this PR? |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
stephmilovic
left a comment
There was a problem hiding this comment.
Can you please write some tests to go with this? Thanks
|
@stephmilovic Could you create a separate issue for #1? Added unit test |
stephmilovic
left a comment
There was a problem hiding this comment.
Thanks for the test woohoooo! LGTM 🚀
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts.saved objects management saved objects edition page allows to delete a saved objectStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
# Conflicts: # x-pack/plugins/security_solution/public/common/components/query_bar/index.test.tsx
* master: (32 commits) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) [kbn/optimizer] only build specified themes (elastic#70389) Fix saved query modal overlay (elastic#68826) Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633) [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634) fix 400 error on initial signals search (elastic#70618) [Maps] fix unable to edit heatmap metric (elastic#70606) Update network idle timeout (elastic#70629) [APM] Disable flaky useFetcher test (elastic#70638) ...
|
Pinging @elastic/security-solution (Team: SecuritySolution) |


Summary
Before:


After: