[Security Solution] Reposition EuiPopovers on scroll#69433
Merged
patrykkopycinski merged 9 commits intoelastic:masterfrom Jul 2, 2020
Merged
[Security Solution] Reposition EuiPopovers on scroll#69433patrykkopycinski merged 9 commits intoelastic:masterfrom
patrykkopycinski merged 9 commits intoelastic:masterfrom
Conversation
…eposition-on-scroll
…eposition-on-scroll
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
This appears to be related: #45021 |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
stephmilovic
approved these changes
Jul 1, 2020
Contributor
stephmilovic
left a comment
There was a problem hiding this comment.
manual testing and code review both LGTM, thanks @patrykkopycinski ! 🥳
…eposition-on-scroll # Conflicts: # x-pack/plugins/security_solution/public/endpoint_alerts/view/details/overview/take_action_dropdown.tsx
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jul 2, 2020
* [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jul 2, 2020
* [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
Jul 2, 2020
* [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
Jul 2, 2020
* [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue found in 7.8.0 BC5 #655 and 7.7.1 #691
Initial Status:
Steps to Reproduce:
floppy diskiconCurrent Behaviour:
Saved Queriesdialog is scrolled along with the SIEM page.Expected Behaviour:
Saved Queriesdialog is not scrolled along with the SIEM page.