[ML] Fix license subscription race condition.#70074
Merged
walterra merged 5 commits intoelastic:masterfrom Jun 30, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
@jgowdyelastic This should fix the license related race condition we discussed. Now with this code + unit test in place I wonder if we should change the code in a way so we enforce the use of |
Contributor
Author
|
@elasticmachine merge upstream |
alvarezmelissa87
approved these changes
Jun 29, 2020
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
LGTM ⚡ Nice fix! 👍
Contributor
Author
|
@elasticmachine merge upstream |
jgowdyelastic
approved these changes
Jun 29, 2020
Member
jgowdyelastic
left a comment
There was a problem hiding this comment.
LGTM
Yes I agree that we could now pass the mlLicense to the App now rather than caching it.
This would be similar to the dependency cache removal work that is needed.
Contributor
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Jun 29, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested locally and LGTM (despite many attempts wasn't able to reproduce the original issue locally. I was only ever able to reproduce on cloud).
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jun 30, 2020
Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup).
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jun 30, 2020
Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup). # Conflicts: # x-pack/plugins/ml/public/application/app.tsx
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jun 30, 2020
Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup). # Conflicts: # x-pack/plugins/ml/public/application/app.tsx
walterra
added a commit
that referenced
this pull request
Jun 30, 2020
Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup).
walterra
added a commit
that referenced
this pull request
Jun 30, 2020
walterra
added a commit
that referenced
this pull request
Jun 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup).
Contributor
Author
|
Tested latest snapshot on cloud staging and can confirm the redirect no longer happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #67365, a regression caused by #59275 introduced in
v7.7.0.Fixes a race condition where the ML plugin would be mounted before receiving its first license information update and thus redirecting to a fallback page (Kibana Home, Space-Chooser or Data Visualizer page depending on the setup).
Checklist
For maintainers