[APM] Add API test for service maps#70185
Merged
sorenlouv merged 6 commits intoelastic:masterfrom Jun 30, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
smith
approved these changes
Jun 29, 2020
Contributor
smith
left a comment
There was a problem hiding this comment.
I had a few question/comments but overall this is great.
Do you think we should extract the testing docs to a separate markdown file? It seems the readme is getting long and dominated by them and it probably will only get worse.
Contributor
Author
Agreed. I'll remove my readme changes and leave that up to @dgieselaar in #70050 |
sorenlouv
commented
Jun 29, 2020
| import { FtrProviderContext } from '../../common/ftr_provider_context'; | ||
|
|
||
| export default function serviceMapsApiTests({ getService }: FtrProviderContext) { | ||
| const supertest = getService('supertest'); |
Contributor
Author
There was a problem hiding this comment.
I'll change this to
Suggested change
| const supertest = getService('supertest'); | |
| const supertestRead = getService('supertestAsApmReadUser'); |
when #70050 is merged
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
sorenlouv
added a commit
that referenced
this pull request
Jul 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* [APM] Add API test for service maps * Re-add custom links test * Improved test names * Disable eslint rule * Undo readme changes * Fix ts errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mission: every APM endpoint should have at least a minimal API test. Most API endpoints are only worth testing if they return APM data. This PR adds an APM data sample and adds a simple test for service maps.
This should make it much easier to create similar tests for other endpoints going forward