[Discover] Deangularize the loading spinner#67165
Merged
stratoula merged 4 commits intoelastic:masterfrom May 25, 2020
Merged
Conversation
mbondyra
reviewed
May 21, 2020
src/plugins/discover/public/application/components/loading_spinner/index.ts
Outdated
Show resolved
Hide resolved
mbondyra
reviewed
May 21, 2020
src/plugins/discover/public/application/components/loading_spinner/loading_spinner.test.tsx
Outdated
Show resolved
Hide resolved
026e15d to
4de5201
Compare
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
kertal
approved these changes
May 25, 2020
Member
|
I tiny nit: could you add a screen+a bit more desc to the PR, 1 click less for our valued QA team |
mbondyra
approved these changes
May 25, 2020
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
didn't test, code LGTM 🆗
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
May 25, 2020
* [Discover] Deangularize the loading spinner * Eslint changes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stratoula
added a commit
that referenced
this pull request
May 25, 2020
jloleysens
added a commit
that referenced
this pull request
May 26, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65449
We have replaced the "Searching" Loader with the Eui Loading Spinner. There is no design change. It looks exactly the same as the previous one.
Checklist