Changed actions API endpoints urls to follow Kibana STYLEGUIDE by YulNaumenko · Pull Request #65936 · elastic/kibana

YulNaumenko · 2020-05-09T00:06:49Z

Resolve #63130 and partially cover some tasks from issue 59799:

Changed actions BASE_ACTION_API_PATH to '/api/actions' - according to styleguide it should keep structure /api/plugin_id
Changed endpoint /_getAll just to /
Changed /types to /list_action_types
Changes POST /api/action to POST /api/actions/action
Changed GET /api/action/{id} to GET /api/actions/action/{id}
Changed PUT /api/action/{id} PUT /api/actions/action/{id}
Changed DELETE /api/action/{id} to DELETE /api/actions/action/{id}
Changed POST /api/action/{id}/_execute to POST /api/actions/action/{id}/_execute

elasticmachine · 2020-05-09T00:06:52Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…w-kibana-styleguide # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…w-kibana-styleguide # Conflicts: # x-pack/plugins/siem/public/containers/case/api.test.tsx

…w-kibana-styleguide # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

gmmorris

LGTM :)

gmmorris · 2020-05-21T11:07:50Z

x-pack/plugins/actions/README.md

 | id       | The id of the action you're trying to delete. | string |

-### `GET /api/action/_getAll`: Get all actions
+### `GET /api/actions`: Get all actions


I like this 👍

pmuellr

I haven't done a full review yet, but the current URLs suggested in the PR aren't sufficiently unique yet. Posted a comment with some suggestions ...

x-pack/plugins/actions/README.md

pmuellr

Beyond the figuring out a new naming schema (as noted in comment), the code LGTM.

x-pack/plugins/actions/README.md

…{id}

FrankHassanabad

Looked over the siem sections and it looks like all URL changes. LGTM

chrisronline

LGTM

…w-kibana-styleguide # Conflicts: # x-pack/plugins/monitoring/public/components/alerts/configuration/step1.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/lib/action_connector_api.ts # x-pack/test/alerting_api_integration/spaces_only/tests/actions/type_not_enabled.ts

kibanamachine · 2020-05-24T02:00:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8d258d6

History

💚 Build #49443 succeeded 01cfa51
💔 Build #49431 failed d6723f4
💔 Build #49426 failed a6aae59
💛 Build #49225 was flaky 9013b45
💔 Build #49183 failed 2e537fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx

…ic#65936) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE * Fixed tests * fixed test * fixed test * resolved conflicts * Fixed siem tests * Fixed failing test * fixed readme and test * Changed actions api urls to follow the template 'api/{plugin}/{type}/{id} * Fixed type checks * Fixed tests and API * fixed tests * Fixed type checks * fixed type check

…ic#65936) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE * Fixed tests * fixed test * fixed test * resolved conflicts * Fixed siem tests * Fixed failing test * fixed readme and test * Changed actions api urls to follow the template 'api/{plugin}/{type}/{id} * Fixed type checks * Fixed tests and API * fixed tests * Fixed type checks * fixed type check # Conflicts: # x-pack/plugins/siem/public/cases/containers/api.test.tsx # x-pack/plugins/siem/public/cases/containers/api.ts # x-pack/test/case_api_integration/basic/tests/cases/push_case.ts

… (#67360) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE * Fixed tests * fixed test * fixed test * resolved conflicts * Fixed siem tests * Fixed failing test * fixed readme and test * Changed actions api urls to follow the template 'api/{plugin}/{type}/{id} * Fixed type checks * Fixed tests and API * fixed tests * Fixed type checks * fixed type check

…ic#65936) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE * Fixed tests * fixed test * fixed test * resolved conflicts * Fixed siem tests * Fixed failing test * fixed readme and test * Changed actions api urls to follow the template 'api/{plugin}/{type}/{id} * Fixed type checks * Fixed tests and API * fixed tests * Fixed type checks * fixed type check # Conflicts: # x-pack/plugins/siem/public/cases/containers/api.test.tsx # x-pack/plugins/siem/public/cases/containers/api.ts # x-pack/test/case_api_integration/basic/tests/cases/push_case.ts

…65936) (#67429) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) * Changed actions API endpoints urls to follow Kibana STYLEGUIDE * Fixed tests * fixed test * fixed test * resolved conflicts * Fixed siem tests * Fixed failing test * fixed readme and test * Changed actions api urls to follow the template 'api/{plugin}/{type}/{id} * Fixed type checks * Fixed tests and API * fixed tests * Fixed type checks * fixed type check # Conflicts: # x-pack/plugins/siem/public/cases/containers/api.test.tsx # x-pack/plugins/siem/public/cases/containers/api.ts # x-pack/test/case_api_integration/basic/tests/cases/push_case.ts * -

rayafratkina · 2020-06-10T18:26:17Z

@YulNaumenko @bmcconaghy this is labeled as release_note:breaking. Are there end user-visible changes in this? If not, it should be release_note:dev_docs

bmcconaghy · 2020-06-11T13:43:17Z

API level, so dev_docs @rayafratkina

Changed actions API endpoints urls to follow Kibana STYLEGUIDE

687f7b0

YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.9.0 labels May 9, 2020

YulNaumenko requested review from a team as code owners May 9, 2020 00:06

YulNaumenko requested a review from a team May 9, 2020 00:06

YulNaumenko self-assigned this May 9, 2020

YulNaumenko added 7 commits May 11, 2020 10:20

Fixed tests

c0f23ed

fixed test

65e7b49

fixed test

7325481

Merge remote-tracking branch 'upstream/master' into actions-api-follo…

6b9da6a

…w-kibana-styleguide # Conflicts: # x-pack/plugins/siem/public/containers/case/api.test.tsx

resolved conflicts

7eb0322

YulNaumenko changed the title ~~[Draft] Changed actions API endpoints urls to follow Kibana STYLEGUIDE~~ Changed actions API endpoints urls to follow Kibana STYLEGUIDE May 13, 2020

YulNaumenko added 4 commits May 20, 2020 11:53

Fixed siem tests

f9dad61

Fixed failing test

70fdbe6

fixed readme and test

9013b45

gmmorris approved these changes May 21, 2020

View reviewed changes

mikecote self-requested a review May 21, 2020 12:13

pmuellr requested changes May 21, 2020

View reviewed changes

x-pack/plugins/actions/README.md Show resolved Hide resolved

pmuellr approved these changes May 21, 2020

View reviewed changes

x-pack/plugins/actions/README.md Show resolved Hide resolved

YulNaumenko added 2 commits May 21, 2020 16:57

Changed actions api urls to follow the template 'api/{plugin}/{type}/…

1710258

…{id}

Fixed type checks

55e487e

YulNaumenko added 2 commits May 21, 2020 17:23

Fixed tests and API

a6aae59

fixed tests

d6723f4

FrankHassanabad approved these changes May 22, 2020

View reviewed changes

chrisronline approved these changes May 22, 2020

View reviewed changes

YulNaumenko added 3 commits May 21, 2020 18:55

Fixed type checks

2426d26

fixed type check

01cfa51

YulNaumenko merged commit d09bd63 into elastic:master May 25, 2020

YulNaumenko mentioned this pull request May 26, 2020

[7.x] Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) #67360

Merged

YulNaumenko mentioned this pull request May 26, 2020

[7.8] Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) #67361

Closed

YulNaumenko mentioned this pull request May 26, 2020

[7.8] Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) #67429

Merged

mikecote added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2020

cnasikas added the v7.8.0 label May 28, 2020

bmcconaghy added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:breaking labels Jun 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed actions API endpoints urls to follow Kibana STYLEGUIDE#65936

Changed actions API endpoints urls to follow Kibana STYLEGUIDE#65936
YulNaumenko merged 19 commits intoelastic:masterfrom
YulNaumenko:actions-api-follow-kibana-styleguide

YulNaumenko commented May 9, 2020 •

edited

Loading

Uh oh!

elasticmachine commented May 9, 2020

Uh oh!

gmmorris left a comment

Uh oh!

gmmorris May 21, 2020

Uh oh!

pmuellr left a comment

Uh oh!

Uh oh!

pmuellr left a comment

Uh oh!

Uh oh!

FrankHassanabad left a comment

Uh oh!

chrisronline left a comment

Uh oh!

kibanamachine commented May 24, 2020

Uh oh!

rayafratkina commented Jun 10, 2020

Uh oh!

bmcconaghy commented Jun 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

YulNaumenko commented May 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented May 9, 2020

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

gmmorris May 21, 2020

Choose a reason for hiding this comment

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FrankHassanabad left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 24, 2020

💚 Build Succeeded

History

Uh oh!

rayafratkina commented Jun 10, 2020

Uh oh!

bmcconaghy commented Jun 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

YulNaumenko commented May 9, 2020 •

edited

Loading