[test_utils/Testbed] Move to src/test_utils folder (OSS)#66898
[test_utils/Testbed] Move to src/test_utils folder (OSS)#66898sebelga merged 26 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
1fcb62a to
de4470b
Compare
jloleysens
left a comment
There was a problem hiding this comment.
Happy for this to be merged when CI is green. Great work @sebelga !
Most CI failures seem to be related to src/plugins/es_ui_shared not existing anymore. Happy to see our object based namespacing be used too!
|
Thanks for the review @jloleysens !
Strangely, only for I had the same issue for |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
This reverts commit c7fc199.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
This PR moves the
"test_utils/testbed"folder and its dependencies ("lib" and "helpers") to the OSS"src/es_ui_shared"folder.This is required so we can test code in our "es_ui_shared" folder, like the form library.
In this PR I also deleted the temporary copy of the test_utils that I had made in #64647.
Note to reviewer
As the only changes are related to test helpers imports, if the CI is green everything should be fine. Maybe make sure I haven't accidentally modified a non-test file.
[EDIT] The intention of this PR is not doable with the current build process. It seems to be because putting test-related code (that depends on jest to be present globally. e.g.
jest.Mock,jest.fn()) does not work inside a plugin as they are built differently. I decided then to move the copy of the testbed and the utils it depends on, out of the "es_ui_shared" plugin and into "src/test_utils" folder. It seems that we already maintain 2 copies ofenzyme_helpers.tsfor that same reason.If we find a solution for the build to pass, then we can revert my 3 last commits (a1d94f8, 516ecb7, 6e6807f)
cc @jloleysens @mistic