Skip to content

Remove prefer_v2_templates query string parameter#66316

Merged
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:remove_prefer_v2_templates
May 13, 2020
Merged

Remove prefer_v2_templates query string parameter#66316
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:remove_prefer_v2_templates

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented May 12, 2020 •
edited
Loading

?prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

elastic/elasticsearch#56546

@tylersmalley
Removes used of prefer_v2_templates
d13dbe8 
prefer_v2_templates is no longer an accepted query parameter. V2
templates are now preferred by default.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 12, 2020
@tylersmalley tylersmalley requested review from a team as code owners May 12, 2020 21:56
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 12, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley changed the title Remove prefer v2 templates Remove prefer v2 templates query parameter May 12, 2020
@tylersmalley tylersmalley changed the title Remove prefer v2 templates query parameter Remove prefer_v2_templates query string parameter May 12, 2020
@tylersmalley tylersmalley force-pushed the remove_prefer_v2_templates branch from 2c2f6b3 to d13dbe8 Compare May 12, 2020 23:52
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented May 12, 2020

Previous success was testing with the current unverified snapshot.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 13, 2020

💚 Build Succeeded

History

  • 💚 Build #47495 succeeded 2c2f6b3361464a436bc6d493b3f7c57953f217f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 3cbb849 into elastic:master May 13, 2020
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented May 13, 2020

Merging prior to CODEOWNERS review as this is blocking the promotion of the ES snapshots. Please raise any concerns if there are any.

@tylersmalley tylersmalley mentioned this pull request May 13, 2020
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request May 13, 2020
@tylersmalley
Removes use of prefer_v2_templates (elastic#66316)
bc4e1f5 
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	x-pack/test/functional/es_archives/endpoint/resolver_tree/api_feature/mappings.json
@tylersmalley tylersmalley mentioned this pull request May 13, 2020
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request May 13, 2020
@tylersmalley
Removes use of prefer_v2_templates (elastic#66316)
3653e19 
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	x-pack/test/functional/es_archives/endpoint/resolver_tree/api_feature/mappings.json
v1v added a commit to v1v/kibana that referenced this pull request May 13, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
58bdbbd 
* upstream/master: (223 commits)
  [Ingest] Support root level yaml variables in agent stream template (elastic#66120)
  [Snapshot Restore] Fix error when deleting snapshots behind reverse proxy (elastic#66147)
  [Lens] fix empty state for pie (elastic#66206)
  [APM] Improve e2e tests (elastic#66373)
  [ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855)
  [Discover] Encode context link filter part (elastic#63831)
  [APM] Scope APM alert creation to environment (elastic#65681)
  Move Kibana Usage collectors outside the telemetry plugin (elastic#65663)
  [ML] Data Frame Analytics: Fix confusion matrix data grid width. (elastic#65818)
  Switch to core application service (elastic#63443)
  Removes use of prefer_v2_templates (elastic#66316)
  [Maps] handle case where fit to bounds does not match any documents (elastic#66307)
  log error instead of throw (elastic#66254)
  [plugin-helpers] remove outdated postinstall task (elastic#66324)
  Spaces - migrate default space and enter space view to KP (elastic#66098)
  [APM] Change plugin id for `apm_oss` to `apmOss` (elastic#66164)
  [Maps] convert map_selectors to TS (elastic#65905)
  [uptime/usage-collector] add missing await (elastic#66079)
  [Ingest] Add additional attributes to the Datasources Saved Object (elastic#66127)
  [Endpoint]EMT-339: add new policy response schema (elastic#66264)
  ...
tylersmalley added a commit that referenced this pull request May 13, 2020
@tylersmalley
Removes use of prefer_v2_templates (#66316) (#66348)
6cc2b5b 
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit that referenced this pull request May 13, 2020
@tylersmalley
Removes use of prefer_v2_templates (#66316) (#66347)
bc20248 
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylersmalley @elasticmachine @kibanamachine @jbudz