[Ingest] Add additional attributes to the Datasources Saved Object#66127
Conversation
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
|
Still draft - need to go through the code usages against the Datasources service and ensure that a |
| revision: { type: 'integer' }, | ||
| updated_on: { type: 'keyword' }, | ||
| updated_by: { type: 'keyword' }, | ||
| created_on: { type: 'keyword' }, |
There was a problem hiding this comment.
Good point @nchaulet . I copied the definition from the Agent Config SO which had keyword, but now see that Enrollment API Keys SO does use date. I will change it.
Thanks 👍
| created_by: { type: 'keyword' }, | ||
| }, | ||
| }, | ||
| migrations: { |
There was a problem hiding this comment.
Even though I don't expect users to migrate from 7.8 to 7.9 I like that we get into the habit of providing a migration path! 👍
…-datasources-additional-fields
…-datasources-additional-fields
|
Ok. I think I have captured all the needed updates for this PR. Its ready for review 😬 |
|
we have a mix of |
| * Generates an Ingest `datasource` that includes the Endpoint Policy data | ||
| */ | ||
| public generatePolicyDatasource(): PolicyData { | ||
| const created = new Date(Date.now() - 8.64e7).toISOString(); // 24h ago |
There was a problem hiding this comment.
I imagine is just for testing purpose?
There was a problem hiding this comment.
Yes, test purposes to mock up data,
|
@nchaulet I'm good with changing the attributes you mentioned to the more commonly used names 👍 |
nchaulet
left a comment
There was a problem hiding this comment.
LGTM for the ingest part (if you can make the change to updated_at|created_at)
++ on using *_at. Looks like we only have one other *_on property (agent config's |
…-datasources-additional-fields
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…lastic#66127) * add additional properties to ingest-datasources SO * Adjusted Types and test generators * Added datasources migrations to SO * Add `user` object to calls to datasource.create()
* upstream/master: (223 commits) [Ingest] Support root level yaml variables in agent stream template (elastic#66120) [Snapshot Restore] Fix error when deleting snapshots behind reverse proxy (elastic#66147) [Lens] fix empty state for pie (elastic#66206) [APM] Improve e2e tests (elastic#66373) [ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855) [Discover] Encode context link filter part (elastic#63831) [APM] Scope APM alert creation to environment (elastic#65681) Move Kibana Usage collectors outside the telemetry plugin (elastic#65663) [ML] Data Frame Analytics: Fix confusion matrix data grid width. (elastic#65818) Switch to core application service (elastic#63443) Removes use of prefer_v2_templates (elastic#66316) [Maps] handle case where fit to bounds does not match any documents (elastic#66307) log error instead of throw (elastic#66254) [plugin-helpers] remove outdated postinstall task (elastic#66324) Spaces - migrate default space and enter space view to KP (elastic#66098) [APM] Change plugin id for `apm_oss` to `apmOss` (elastic#66164) [Maps] convert map_selectors to TS (elastic#65905) [uptime/usage-collector] add missing await (elastic#66079) [Ingest] Add additional attributes to the Datasources Saved Object (elastic#66127) [Endpoint]EMT-339: add new policy response schema (elastic#66264) ...
Summary
Adds 4 additional attributes to the Datasources Saved Object (created/updated_by ++ created/updated_on). In support of this change, a datasources saved object migration was also created for v7.9.0
closes #65904
Checklist
Delete any items that are not applicable to this PR.
(Elasticsearch + kibana was started using
master. Datasources where created using the UI. Source was then switched to the branch containing these changed (Kibana server was restarted). Looking at the API calls made by the UI, I can see the new attributes being returned)