Remove prefer_v2_templates query string parameter#56546
Merged
dakrone merged 2 commits intoelastic:masterfrom May 11, 2020
Merged
Remove prefer_v2_templates query string parameter#56546dakrone merged 2 commits intoelastic:masterfrom
dakrone merged 2 commits intoelastic:masterfrom
Conversation
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that allowed specifying whether V1 or V2 template should be used when an index is created. It has been removed in favor of V2 templates always having priority. Relates to elastic#53101 Resolves elastic#56528 This is not a breaking change because this flag was never in a released version.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
Member
Author
Member
Author
probakowski
approved these changes
May 11, 2020
Contributor
probakowski
left a comment
There was a problem hiding this comment.
LGTM, one small thing that can be skipped if you want
| } | ||
|
|
||
| @Override | ||
| protected BulkRequest buildBulk(Iterable<? extends ScrollableHitSource.Hit> docs) { |
Contributor
There was a problem hiding this comment.
As we removed only overriding method we can change it back to private in parent class
Member
Author
|
@elasticmachine update branch |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 11, 2020
This can only be merged once elastic#56541, elastic#56545 and elastic#56546 have been merged
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 11, 2020
This can only be merged once elastic#56541, elastic#56545 and elastic#56546 have been merged
This was referenced May 11, 2020
2 tasks
dakrone
added a commit
that referenced
this pull request
May 11, 2020
dakrone
added a commit
that referenced
this pull request
May 11, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
prefer_v2_templatesflag and setting. This was a brief setting thatallowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.
Relates to #53101
Resolves #56528
This is not a breaking change because this flag was never in a released version.