Skip to content

Remove prefer_v2_templates query string parameter#56545

Merged
dakrone merged 2 commits intoelastic:7.xfrom
dakrone:itv2-7.x-remove-prefer-flag
May 11, 2020
Merged

Remove prefer_v2_templates query string parameter#56545
dakrone merged 2 commits intoelastic:7.xfrom
dakrone:itv2-7.x-remove-prefer-flag

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented May 11, 2020

This commit removes the prefer_v2_templates flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to #53101
Resolves #56528

This is not a breaking change because this flag was never in a released version.

This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to elastic#53101
Resolves elastic#56528

This is not a breaking change because this flag was never in a released version.
@dakrone dakrone added >non-issue :Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. v7.9.0 labels May 11, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label May 11, 2020
@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented May 11, 2020

This needs #56543 and #56542 to be merged prior to being merged

Copy link
Copy Markdown
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented May 11, 2020

@elasticmachine update branch

dakrone added a commit to dakrone/elasticsearch that referenced this pull request May 11, 2020
This can only be merged once elastic#56541, elastic#56545 and elastic#56546 have been merged
dakrone added a commit that referenced this pull request May 11, 2020
This can only be merged once #56541, #56545 and #56546 have been merged
dakrone added a commit to dakrone/elasticsearch that referenced this pull request May 11, 2020
This can only be merged once elastic#56541, elastic#56545 and elastic#56546 have been merged
@dakrone dakrone merged commit 1337b35 into elastic:7.x May 11, 2020
@dakrone dakrone deleted the itv2-7.x-remove-prefer-flag branch May 11, 2020 20:56
dakrone added a commit that referenced this pull request May 11, 2020
This can only be merged once #56541, #56545 and #56546 have been merged
dakrone added a commit that referenced this pull request May 11, 2020
This can only be merged once #56541, #56545 and #56546 have been merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. >non-issue Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants