Add sub-menus to Resolver node (for 75% zoom)#63476
Merged
bkimmel merged 13 commits intoelastic:masterfrom Apr 20, 2020
bkimmel:resolver/add-node-submenus
Merged
Add sub-menus to Resolver node (for 75% zoom)#63476bkimmel merged 13 commits intoelastic:masterfrom bkimmel:resolver/add-node-submenus
bkimmel merged 13 commits intoelastic:masterfrom
bkimmel:resolver/add-node-submenus
Conversation
lindseypoli
approved these changes
Apr 17, 2020
| alias: 'ai', | ||
| describe: 'index to store alerts in', | ||
| default: '.alerts-endpoint-000001', | ||
| default: 'events-endpoint-1', |
Contributor
There was a problem hiding this comment.
@bkimmel I agree that we should probably keep this as events-endpoint-1 since that's what the app is looking for in master.
@elastic/endpoint-response are you ok with this?
| }, | ||
| }; | ||
|
|
||
| const ChildEventsButton = () => { |
Contributor
There was a problem hiding this comment.
Not sure if it's useful but should we add the data-test-subj to any of these buttons? @achuguy @IgorGuz2000
Contributor
There was a problem hiding this comment.
we should add data-test-subj attributes in the PR where they are used.
oatkiller
reviewed
Apr 17, 2020
x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx
Show resolved
Hide resolved
oatkiller
reviewed
Apr 17, 2020
| const RelatedAlertsButton = () => { | ||
| return ( | ||
| <EuiButton | ||
| onClick={(clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => { |
Contributor
There was a problem hiding this comment.
can you wrap the functions in useCallback, this way EuiButton will get the same function reference each time RelatedAlertsButton is rendered, and EuiButton won't necessarily have to rerender just because its parent did.
<EuiButton
onClick={useCallback((clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
clickEvent.preventDefault();
clickEvent.stopPropagation();
}, [])}
oatkiller
reviewed
Apr 17, 2020
| const ChildEventsButton = () => { | ||
| return ( | ||
| <EuiButton | ||
| onClick={(clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => { |
Contributor
There was a problem hiding this comment.
same thing as below, but could you wrap the function in useCallback
oatkiller
reviewed
Apr 17, 2020
| }, | ||
| }; | ||
|
|
||
| const ChildEventsButton = () => { |
Contributor
There was a problem hiding this comment.
you can wrap these new components in
React.memo if ya want:
oatkiller
suggested changes
Apr 17, 2020
Contributor
oatkiller
left a comment
There was a problem hiding this comment.
:+1 but could you add React.memo and useCallback in a few places. This code will run on every frame after all.
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
Contributor
Author
|
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
oatkiller
approved these changes
Apr 20, 2020
jonathan-buttner
approved these changes
Apr 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 21, 2020
* master: (30 commits) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) [TSVB] Use default Kibana palette for split series (elastic#62241) Ingest overview page (elastic#63214) ...
jloleysens
added a commit
that referenced
this pull request
Apr 21, 2020
…t-node-pipelines * 'master' of github.com:elastic/kibana: (32 commits) Move authz lib out of snapshot restore (#63947) Migrate vis_type_table to kibana/new platform (#63105) Enable include/exclude in Terms agg for numeric fields (#59425) follow conventions for saved object definitions (#63571) [Docs]Adds saved object key setting to load balancing kib instances (#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (#63838) Fix page layouts, clean up unused code (#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (#63859) [Maps] Do not fetch geo_shape from docvalues (#63997) Vega doc changes (#63889) [Metrics UI] Reorganize file layout for Metrics UI (#60049) Add sub-menus to Resolver node (for 75% zoom) (#63476) [FTR] Add test suite metrics tracking/output (#62515) [ML] Fixing single metric viewer page padding (#63839) [Discover] Allow user to generate a report after saving a modified saved search (#63623) [Reporting] Config flag to escape formula CSV values (#63645) [Metrics UI] Remove remaining field filtering (#63398) [Maps] fix date labels (#63909) [TSVB] Use default Kibana palette for split series (#62241) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 21, 2020
…bana into ingest-node-pipelines/privileges * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) ... # Conflicts: # x-pack/legacy/plugins/uptime/public/components/monitor/ml/index.ts # x-pack/legacy/plugins/uptime/public/components/overview/index.ts # x-pack/plugins/ingest_pipelines/public/application/index.tsx # x-pack/plugins/ingest_pipelines/server/routes/api/index.ts # x-pack/plugins/ingest_pipelines/server/routes/index.ts
bkimmel
added a commit
that referenced
this pull request
Apr 21, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 22, 2020
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits) [Ingest Node Pipelines] Clone Pipeline (elastic#64049) Move authz lib out of snapshot restore (elastic#63947) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [Ingest pipelines] Delete pipeline (elastic#63635) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds submenus to resolver nodes to match the 75% zoom level. It adds a FlexGroup to manage alignment/gutters for the submenu buttons.
of note:
Screenshots
Mocks
These are mocks for reference only
NOT SCREENSHOTS
NOT SCREENSHOTS
Checklist
Delete any items that are not applicable to this PR.
(https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
For maintainers