Skip to content

Convert Timeline to TypeScript#59966

Merged
smith merged 1 commit intoelastic:masterfrom
smith:nls/timeline-ts
Mar 12, 2020
Merged

Convert Timeline to TypeScript#59966
smith merged 1 commit intoelastic:masterfrom
smith:nls/timeline-ts

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Mar 11, 2020

Will need to be touching some of these soon as part of elastic/observability-dev#532 so I'm converting to TypeScript.

Get rid of default exports on all of them as well.

@smith smith requested a review from a team March 11, 2020 23:07
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 11, 2020
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow...!

Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better 👍

Will need to be touching some of these soon as part of elastic/observability-dev#532 so I'm converting to TypeScript.

Get rid of default exports on all of them as well.
@smith smith force-pushed the nls/timeline-ts branch from 0ce1141 to ffd66b0 Compare March 12, 2020 14:09
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

  • 💔 Build #32631 failed 0ce1141b374602847ff5b88a7308787832635b79

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 99c35f6 into elastic:master Mar 12, 2020
@smith smith deleted the nls/timeline-ts branch March 12, 2020 20:03
smith added a commit to smith/kibana that referenced this pull request Mar 12, 2020
Will need to be touching some of these soon as part of elastic/observability-dev#532 so I'm converting to TypeScript.

Get rid of default exports on all of them as well.
smith added a commit that referenced this pull request Mar 12, 2020
Will need to be touching some of these soon as part of elastic/observability-dev#532 so I'm converting to TypeScript.

Get rid of default exports on all of them as well.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 13, 2020
* master:
  [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756)
  [Ingest] Fix data source creation and double system data source (elastic#60069)
  Add button to view full service map (elastic#59394)
  unskip tests for code coverage (elastic#59725)
  [Ingest] Add Fleet & EPM features (elastic#59376)
  [Logs UI] Show navigation bar while loading source configurati… (elastic#59997)
  [Endpoint] ERT-82 Alerts search bar (elastic#59702)
  Aggregate queue types being used by Beats (elastic#59850)
  skip flaky suite (elastic#59541)
  Convert Timeline to TypeScript (elastic#59966)
  Make context.core required argument to context providers (elastic#59996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants