[Endpoint] ERT-82 Alerts search bar by peluja1012 · Pull Request #59702 · elastic/kibana

peluja1012 · 2020-03-09T20:23:40Z

Summary

Integrates Stateful Search Bar (from kibana/src/plugins/data) into the Endpoint App's Alerts page. This PR also syncs the Search Bar's state with the browser url.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-03-09T20:23:42Z

Pinging @elastic/endpoint-response (Team:Endpoint Response)

elasticmachine · 2020-03-09T20:23:44Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

EricDavisX · 2020-03-10T15:29:45Z

Would love to talk about what tests you want to put in for this, what we think is warranted and useful. If you can help find and link file for the search bar component that we're re-using that would help to know what tests it already has so we can focus this pr to testing only what is needed and at what right level.

oatkiller · 2020-03-11T15:12:07Z

x-pack/plugins/endpoint/server/routes/alerts/list/lib/index.ts

Does decode need any error handling or anything? Curious because this will have typescript trust that the value is a Query. What happens if the decode fails?

@oatkiller In this case, the schema will have already validated the input, so we should be okay, no? Or do you think we should handle this differently? In any case, we should have API-level tests to check for a 400 and ensure there's no 500 when invalid input is provided. @peluja1012 <<<

oatkiller · 2020-03-11T15:20:38Z

x-pack/plugins/endpoint/public/applications/endpoint/store/alerts/middleware.ts

this seems fine

oatkiller · 2020-03-11T15:23:08Z

x-pack/plugins/endpoint/public/applications/endpoint/store/alerts/selectors.ts

this unsafe cast makes me think we might need error handling

https://github.com/elastic/endpoint-app-team/issues/265

oatkiller · 2020-03-11T15:24:53Z

x-pack/plugins/endpoint/public/applications/endpoint/store/index.ts

Could you add a doc comment here explaining the behavior when no middleware deps are passed

madirey · 2020-03-12T15:37:44Z

x-pack/plugins/endpoint/common/schema/alert_index.ts

Shouldn't this be decoded and then run through fromKueryExpression still? To check both cases? Or are we changing the format of query?

@madirey We're changing the format of query to be of type Query, which has a query and a language (kql or lucene)

kibanamachine · 2020-03-12T17:42:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c76d52e

History

💔 Build #32753 failed ae84cea8a94691091505a0604039fe1ed383f37e
💔 Build #32013 failed 0c60c232b99a12c73ee7cab45fca590fe4bbd4e9
💔 Build #31903 failed 65247bfb1b3d6dd7683d13a4b69bd440c78a2835

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)

kibanamachine · 2020-03-13T20:48:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59702 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-03-14T20:58:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59702 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-03-15T21:08:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59702 or prevent reminders by adding the backport:skip label.

* Add SearchBar UI. Query, filter, and dateRange work * Sync url with search bar, fix excluded filters on BE * fix welcome title * Use KibanaReactContext, fix indexPattern fetch * Mock data plugin, api and ui tests pass * Add view and functional tests * use observables to handle filter updates * address comments

peluja1012 added WIP Work in progress Team:Endpoint Response Endpoint Response Team Feature:Endpoint Elastic Endpoint feature labels Mar 9, 2020

oatkiller reviewed Mar 11, 2020

View reviewed changes

peluja1012 force-pushed the alerts-search-bar branch from 8b07361 to 8008245 Compare March 12, 2020 11:28

peluja1012 marked this pull request as ready for review March 12, 2020 13:01

peluja1012 requested a review from a team as a code owner March 12, 2020 13:01

peluja1012 added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed WIP Work in progress labels Mar 12, 2020

peluja1012 requested review from kqualters-elastic and paul-tavares March 12, 2020 13:27

madirey reviewed Mar 12, 2020

View reviewed changes

peluja1012 added 8 commits March 12, 2020 12:01

Add SearchBar UI. Query, filter, and dateRange work

7a624a7

Sync url with search bar, fix excluded filters on BE

0843402

fix welcome title

572715d

Use KibanaReactContext, fix indexPattern fetch

4b4a717

Mock data plugin, api and ui tests pass

9f75a5d

Add view and functional tests

fb55a92

use observables to handle filter updates

7a8ab62

address comments

c76d52e

peluja1012 force-pushed the alerts-search-bar branch from ae84cea to c76d52e Compare March 12, 2020 16:02

oatkiller approved these changes Mar 12, 2020

View reviewed changes

dplumlee approved these changes Mar 12, 2020

View reviewed changes

peluja1012 changed the title ~~[Endpoint] Alerts search bar~~ [Endpoint] ERT-82 Alerts search bar Mar 12, 2020

peluja1012 merged commit cf5c801 into elastic:master Mar 12, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 13, 2020

peluja1012 mentioned this pull request Mar 16, 2020

[7.x] [Endpoint] ERT-82 Alerts search bar (#59702) #60288

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 16, 2020

Conversation

peluja1012 commented Mar 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 9, 2020

Uh oh!

elasticmachine commented Mar 9, 2020

Uh oh!

EricDavisX commented Mar 10, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 12, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Mar 13, 2020

Uh oh!

kibanamachine commented Mar 14, 2020

Uh oh!

kibanamachine commented Mar 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

peluja1012 commented Mar 9, 2020 •

edited

Loading