Aggregate queue types being used by Beats#59850
Merged
ycombinator merged 7 commits intoelastic:masterfrom Mar 12, 2020
Merged
Conversation
4c54413 to
527b2fd
Compare
Contributor
|
How can I make these stats show up? I'm seeing |
afharo
approved these changes
Mar 12, 2020
Member
afharo
left a comment
There was a problem hiding this comment.
LGTM! I haven't tested it, though.
afharo
requested changes
Mar 12, 2020
Member
afharo
left a comment
There was a problem hiding this comment.
The types for BeatsBaseStats need to include the new queue entries
Contributor
Author
@afharo I'm not familiar with Typescript so hopefully I did the right thing in 2076d80. |
chrisronline
suggested changes
Mar 12, 2020
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
You need to update the filterPath to include the new queue path: https://github.com/elastic/kibana/pull/59850/files#diff-ed4dfe3e626069cc7ad7e5b1a85d18bbR346
Contributor
Author
|
Thanks @chrisronline for catching this! |
afharo
approved these changes
Mar 12, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Mar 12, 2020
* Aggregate queue types being used by Beats * Making tests pass again * Updating fixture + tests for queue type * Adding queue field to BeatsBaseStats type * Add undefined guard * Adding queue field to source fields list * Fixing type error
ycombinator
added a commit
that referenced
this pull request
Mar 12, 2020
* Aggregate queue types being used by Beats * Making tests pass again * Updating fixture + tests for queue type * Adding queue field to BeatsBaseStats type * Add undefined guard * Adding queue field to source fields list * Fixing type error
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 13, 2020
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR teaches the telemetry collection code in Kibana to count the various queue types (mem or spool) used by Beats in a cluster.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately