Skip to content

expand max-old-space-size for xpack jest tests#59455

Merged
spalger merged 4 commits intoelastic:masterfrom
spalger:fix/xpack-jest-oom
Mar 5, 2020
Merged

expand max-old-space-size for xpack jest tests#59455
spalger merged 4 commits intoelastic:masterfrom
spalger:fix/xpack-jest-oom

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Mar 5, 2020

We've seen two OOMs for the x-pack jest tests on master, so as a temporary "fix" we should expand the max-old-space-size and I'm going to dig in a little and see if I can track down where we're running out of memory.

NOTE: jest-worker passes through all execArgv to the workers https://github.com/facebook/jest/blob/master/packages/jest-worker/src/workers/ChildProcessWorker.ts#L92

@spalger spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 5, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Copy Markdown
Member

@spalger, this is currently being set to 4096 here. We could increase that number, overwrite to something higher where you have done here, or possibly investigate splitting up the x-pack Jest tests to see if that decreases the amount of memory overhead.

@tylersmalley
Copy link
Copy Markdown
Member

I verified it can be ran within 6GB

@spalger spalger merged commit 5408f45 into elastic:master Mar 5, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 5, 2020
* expand max-old-space-size for xpack jest tests

* turns out we are already at 4GB

* limit to 6GB for now
spalger pushed a commit that referenced this pull request Mar 5, 2020
* expand max-old-space-size for xpack jest tests

* turns out we are already at 4GB

* limit to 6GB for now
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Mar 5, 2020

7.x/7.7: 982b2bf

@spalger spalger deleted the fix/xpack-jest-oom branch March 5, 2020 23:06
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 6, 2020
…x-closed-index

* 'master' of github.com:elastic/kibana: (32 commits)
  [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320)
  [APM] Create settings page to manage Custom Links (elastic#57788)
  [Upgrade Assistant] Server-side batch reindexing (elastic#58598)
  completes navigation test (elastic#59141)
  [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476)
  [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683)
  [SIEM] [CASES] API with io-ts validation (elastic#59265)
  Use camelCase rather than snakeCase for plugin name (elastic#59461)
  [Maps] top term percentage field property (elastic#59386)
  Add custom action to registry and show actions list in siem (elastic#58395)
  [Search service] Add enhanced ES search strategy (elastic#59224)
  [Logs UI] Speed up stream rendering using memoization (elastic#59163)
  expand max-old-space-size for xpack jest tests (elastic#59455)
  Added possibility to embed connectors create and edit flyouts (elastic#58514)
  Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491)
  Temporarily disabling PR project mappings (elastic#59485)
  [Endpoint] Fix alert list functional test error (elastic#59357)
  Rename status_page to statusPage (elastic#59186)
  Fix visual baseline job (elastic#59348)
  Extended AlertContextValue with metadata optional property (elastic#59391)
  ...

# Conflicts:
#	x-pack/plugins/upgrade_assistant/common/types.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants