Extended AlertContextValue with metadata optional property#59391

Merged

YulNaumenko merged 2 commits intoelastic:masterfrom

YulNaumenko:alerting-extend-alerts-context-with-metadata

Mar 5, 2020

Contributor

YulNaumenko commented Mar 5, 2020 •

edited

Loading

Resolve #58532

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios


          Extended AlertContextValue with metadata optional property

b796ada

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip v7.7.0 Team:ResponseOps labels

YulNaumenko requested a review from a team as a code owner

March 5, 2020 00:12

YulNaumenko self-assigned this

Contributor

elasticmachine commented Mar 5, 2020

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

pmuellr approved these changes

View reviewed changes

Contributor

pmuellr left a comment

LGTM

phillipb reviewed

View reviewed changes

Contributor

phillipb left a comment

Nice work! I've verified that this works for me. Small ask about types, but other than that LGTM

x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx Outdated Show resolved Hide resolved


          Made metadata generic

8860cf8

phillipb approved these changes

View reviewed changes

Contributor

phillipb left a comment

LGTM

Contributor

kibanamachine commented Mar 5, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8860cf8

History

💚 Build #30962 succeeded b796ada

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

YulNaumenko merged commit 26aed8d into elastic:master

YulNaumenko mentioned this pull request

[7.x] Extended AlertContextValue with metadata optional property (#59391) #59474

Merged

YulNaumenko added a commit that referenced this pull request


          [7.x] Extended AlertContextValue with metadata optional property (#59391

c8c3ebb

) (#59474)

* no message

* Fixed type check

* changed ci groups

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          Merge branch 'master' of github.com:elastic/kibana into ua/fix/reinde…

d73316a

…x-closed-index

* 'master' of github.com:elastic/kibana: (32 commits)
  [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320)
  [APM] Create settings page to manage Custom Links (elastic#57788)
  [Upgrade Assistant] Server-side batch reindexing (elastic#58598)
  completes navigation test (elastic#59141)
  [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476)
  [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683)
  [SIEM] [CASES] API with io-ts validation (elastic#59265)
  Use camelCase rather than snakeCase for plugin name (elastic#59461)
  [Maps] top term percentage field property (elastic#59386)
  Add custom action to registry and show actions list in siem (elastic#58395)
  [Search service] Add enhanced ES search strategy (elastic#59224)
  [Logs UI] Speed up stream rendering using memoization (elastic#59163)
  expand max-old-space-size for xpack jest tests (elastic#59455)
  Added possibility to embed connectors create and edit flyouts (elastic#58514)
  Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491)
  Temporarily disabling PR project mappings (elastic#59485)
  [Endpoint] Fix alert list functional test error (elastic#59357)
  Rename status_page to statusPage (elastic#59186)
  Fix visual baseline job (elastic#59348)
  Extended AlertContextValue with metadata optional property (elastic#59391)
  ...

# Conflicts:
#	x-pack/plugins/upgrade_assistant/common/types.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts
#	x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts

kibanamachine added the backport missing label

Contributor

kibanamachine commented Mar 6, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

5 similar comments

Contributor

kibanamachine commented Mar 7, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 8, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 9, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 10, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Mar 11, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59391 or prevent reminders by adding the backport:skip label.

YulNaumenko added backported and removed backport missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Feature:Alerting release_note:skip Team:ResponseOps v7.7.0 v8.0.0