Added possibility to embed connectors create and edit flyouts#58514
Merged
YulNaumenko merged 15 commits intoelastic:masterfrom Mar 5, 2020
Merged
Added possibility to embed connectors create and edit flyouts#58514YulNaumenko merged 15 commits intoelastic:masterfrom
YulNaumenko merged 15 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
2 tasks
…_ui_embedding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…_ui_embedding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…_ui_embedding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…_ui_embedding # Conflicts: # x-pack/plugins/triggers_actions_ui/public/index.ts # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts
pmuellr
approved these changes
Mar 5, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
code LGTM, left a few comments
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts
Outdated
Show resolved
Hide resolved
mikecote
approved these changes
Mar 5, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
LGTM just a few nits and comments 👍
x-pack/plugins/triggers_actions_ui/public/application/context/actions_connectors_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts
Outdated
Show resolved
Hide resolved
...s_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.test.tsx
Outdated
Show resolved
Hide resolved
…_ui_embedding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…_ui_embedding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 5, 2020
…c#58514) * Added possibility to embed connectors flyout * Fixed type checks and removed example from siem start page * Fixed jest tests * Fixed failing tests * fixed type check * Added config for siem tests * Fixed failing tests * Fixed due to comments * Added missing documentation
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
that referenced
this pull request
Mar 6, 2020
#59496) * Added possibility to embed connectors flyout * Fixed type checks and removed example from siem start page * Fixed jest tests * Fixed failing tests * fixed type check * Added config for siem tests * Fixed failing tests * Fixed due to comments * Added missing documentation
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 6, 2020
…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #58530
Checklist
Delete any items that are not applicable to this PR.