[ML] Fixing licensing after server NP cutover#58853
Merged
jgowdyelastic merged 15 commits intoelastic:masterfrom Mar 3, 2020
Merged
[ML] Fixing licensing after server NP cutover#58853jgowdyelastic merged 15 commits intoelastic:masterfrom
jgowdyelastic merged 15 commits intoelastic:masterfrom
Conversation
b58b144 to
cd797b8
Compare
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
retest |
walterra
reviewed
Mar 2, 2020
Contributor
walterra
left a comment
There was a problem hiding this comment.
Code looks good overall, just added some question regarding licensing for data visualizer.
756a443 to
4687504
Compare
Member
Author
|
retest |
x-pack/plugins/ml/server/lib/check_privileges/check_privileges.ts
Outdated
Show resolved
Hide resolved
4687504 to
e9fdc8c
Compare
peteharverson
approved these changes
Mar 3, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested with a range of licenses and security settings and LGTM.
Member
Author
|
@elasticmachine merge upstream |
alvarezmelissa87
approved these changes
Mar 3, 2020
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Latest edits LGTM ⚡️
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 3, 2020
* [ML] Fixing licensing after server NP cutover * client side refactor * management refactor * moving management license check * adding server side license class * added common license class * client sides using license class * updating server api guards * fix privileges tests * updating translations * fixing disabled tabs on basic license * refactoring client side license checks * setting license initialized flag * fixing license check on index data viz Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Mar 3, 2020
This reverts commit fd5c6c1.
jbudz
added a commit
that referenced
this pull request
Mar 3, 2020
2 tasks
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/lens_reporting·ts.lens app lens reporting should not cause PDF reports to failStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/lens_reporting·ts.lens app lens reporting should not cause PDF reports to failStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS WAS REVERTED.
The PR you're looking for is #59275
Reenables the license checking for server and client sides after server side cutover (#58680)
A shared common
mlLicenseclass has been added which listens to the licensing updates from the licensing plugin.The server and client then have specialised derived classes which add on checks specific to their needs
Server side
Basic enabled endpoints:
/api/ml/fields_service/time_field_range/api/ml/file_data_visualizer/analyze_file/api/ml/file_data_visualizer/import/api/ml/_has_privileges/api/ml/ml_capabilities/api/ml/ml_node_count/api/ml/info/api/ml/data_visualizer/get_field_stats/{indexPatternTitle}/api/ml/data_visualizer/get_overall_stats/{indexPatternTitle}Client side:
hasLicenseExpiredandisFullLicensegeneral functions which are used in a few places throughout our UI.Also fixes the management plugin which was being disabled due to its licensing check.
Checklist
Delete any items that are not applicable to this PR.
For maintainers