Skip to content

Revert "[ML] Fixing licensing after server NP cutover (#58853)"#59244

Merged
jbudz merged 1 commit intoelastic:masterfrom
jbudz:revert/ml-licensing
Mar 3, 2020
Merged

Revert "[ML] Fixing licensing after server NP cutover (#58853)"#59244
jbudz merged 1 commit intoelastic:masterfrom
jbudz:revert/ml-licensing

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Mar 3, 2020

This reverts commit fd5c6c1.

cc @jgowdyelastic
https://kibana-ci.elastic.co/view/Kibana/job/elastic+kibana+master/3392/execution/node/471/log/?consoleFull

16:09:39                 └- ✓ pass  (24.4s) "security app Security Login Page displays message acknowledging logout"
16:09:39               └-> "after each" hook
16:09:39               └-: within a non-default space
16:09:39                 └-> "before all" hook
16:09:39                 └-> "before all" hook
16:09:39                 └-> logging out of a non-default space redirects to the login page at the server root
16:09:39                   └-> "before each" hook: global before each
16:10:01                   │ERROR browser[SEVERE] http://localhost:6141/s/some-space/bundles/plugin/licensing/licensing.plugin.js 14:151761 Uncaught TypeError: Cannot read property 'unsubscribe' of undefined
16:10:08                   └- ✓ pass  (30.1s) "security app Security Login Page within a non-default space logging out of a non-default space redirects to the login page at the server root"

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@jbudz jbudz requested a review from a team as a code owner March 3, 2020 23:06
@jbudz jbudz added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 3, 2020
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Mar 3, 2020

@elastic/ml-ui sorry about the force revert - context above. please ping if there's any concerns

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic
Copy link
Copy Markdown
Member

@jbudz no worries, thanks for resolving the issue.
it's odd that I got a green CI when it had this problem.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 4, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59244 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59244 or prevent reminders by adding the backport:skip label.

@jgowdyelastic jgowdyelastic added the backport:skip This PR does not require backporting label Mar 6, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants